|
Hello,
On Thu, 16 Jul 2015, Raducu Deaconu wrote:
> Hi,
> I have updated the code and generated the patch, according to your
> indications.
When patch is attached it is difficult to
comment it. Anyways, I'll try.
- The Subject should include "ipvs: ",
eg. Subject: [PATCH] ipvs: add ovf scheduler
- In Kconfig the "tristate..." line has wrong indentation,
one tab should be removed
- When debugging is enabled (CONFIG_IP_VS_DEBUG=y) the module
does not compile, you can also use short var names, eg:
struct ip_vs_dest *dest, *h = NULL;
int hw = 0, w;
- the comment block "select the node..." has one empty line
at end, should be removed
- the 'if ...' blocks in the loop are not properly indented
Regards
--
Julian Anastasov <ja@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
|
