LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH] netfilter: ipvs: avoid unused variable warning

To: Arnd Bergmann <arnd@xxxxxxxx>
Subject: Re: [PATCH] netfilter: ipvs: avoid unused variable warning
Cc: Wensong Zhang <wensong@xxxxxxxxxxxx>, Simon Horman <horms@xxxxxxxxxxxx>, lvs-devel@xxxxxxxxxxxxxxx, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>, Patrick McHardy <kaber@xxxxxxxxx>, Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx
From: Julian Anastasov <ja@xxxxxx>
Date: Mon, 30 Nov 2015 22:48:34 +0200 (EET)
        Hello,

On Mon, 30 Nov 2015, Arnd Bergmann wrote:

> When CONFIG_PROC_FS is disabled, the local 'net' variable in
> ip_vs_app_net_init becomes unused, as gcc warns:
> 
> net/netfilter/ipvs/ip_vs_app.c: In function 'ip_vs_app_net_init':
> net/netfilter/ipvs/ip_vs_app.c:608:14: warning: unused variable 'net' 
> [-Wunused-variable]
> 
> This removes the line by moving the pointer dereference into the
> user of the variable.
> 
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Acked-by: Julian Anastasov <ja@xxxxxx>

> diff --git a/net/netfilter/ipvs/ip_vs_app.c b/net/netfilter/ipvs/ip_vs_app.c
> index 0328f7250693..e5422d3db501 100644
> --- a/net/netfilter/ipvs/ip_vs_app.c
> +++ b/net/netfilter/ipvs/ip_vs_app.c
> @@ -614,8 +614,6 @@ int __net_init ip_vs_app_net_init(struct netns_ipvs *ipvs)
>  
>  void __net_exit ip_vs_app_net_cleanup(struct netns_ipvs *ipvs)
>  {
> -     struct net *net = ipvs->net;
> -
>       unregister_ip_vs_app(ipvs, NULL /* all */);
> -     remove_proc_entry("ip_vs_app", net->proc_net);
> +     remove_proc_entry("ip_vs_app", ipvs->net->proc_net);
>  }

Regards

--
Julian Anastasov <ja@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>