Re: [PATCH v2] ipvs: add checksum support for gue encapsulation

To:	Jacky Hu <hengqing.hu@xxxxxxxxx>
Subject:	Re: [PATCH v2] ipvs: add checksum support for gue encapsulation
Cc:	jacky.hu@xxxxxxxxxxx, jason.niesz@xxxxxxxxxxx, Wensong Zhang <wensong@xxxxxxxxxxxx>, Simon Horman <horms@xxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Alexey Kuznetsov <kuznet@xxxxxxxxxxxxx>, Hideaki YOSHIFUJI <yoshfuji@xxxxxxxxxxxxxx>, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>, Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxxxxxx>, Florian Westphal <fw@xxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx
From:	Julian Anastasov <ja@xxxxxx>
Date:	Wed, 29 May 2019 01:04:14 +0300 (EEST)

        Hello,

On Sun, 26 May 2019, Jacky Hu wrote:

> +/* Tunnel encapsulation flags */
> +#define IP_VS_TUNNEL_ENCAP_FLAG_NOCSUM               (0)
> +#define IP_VS_TUNNEL_ENCAP_FLAG_CSUM         (1<<0)
> +#define IP_VS_TUNNEL_ENCAP_FLAG_REMCSUM              (1<<1)

        scripts/checkpatch.pl --strict file.patch
reports for some issues you should resolve for v3.
Otherwise, the patch looks good to me.

Regards

--
Julian Anastasov <ja@xxxxxx>

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH v2] ipvs: add checksum support for gue encapsulation, Jacky Hu Re: [PATCH v2] ipvs: add checksum support for gue encapsulation, Julian Anastasov <=

Previous by Date:	memory leak in start_sync_thread, syzbot
Next by Date:	[PATCH v3] ipvs: add checksum support for gue encapsulation, Jacky Hu
Previous by Thread:	[PATCH v2] ipvs: add checksum support for gue encapsulation, Jacky Hu
Next by Thread:	[PATCH v6 1/2] ipvsadm: convert options to unsigned long long, Jacky Hu
Indexes:	[Date] [Thread] [Top] [All Lists]