Re: [PATCH] netfilter: ipvs: Use the bitmap API to allocate bitmaps

[Julian Anastasov <ja@xxxxxx>]

        Hello,

On Mon, 4 Jul 2022, Christophe JAILLET wrote:

> Use bitmap_zalloc()/bitmap_free() instead of hand-writing them.
> 
> It is less verbose and it improves the semantic.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@xxxxxxxxxx>

        Looks good to me for -next! Thanks!

Acked-by: Julian Anastasov <ja@xxxxxx>

> ---
>  net/netfilter/ipvs/ip_vs_mh.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/net/netfilter/ipvs/ip_vs_mh.c b/net/netfilter/ipvs/ip_vs_mh.c
> index da0280cec506..e3d7f5c879ce 100644
> --- a/net/netfilter/ipvs/ip_vs_mh.c
> +++ b/net/netfilter/ipvs/ip_vs_mh.c
> @@ -174,8 +174,7 @@ static int ip_vs_mh_populate(struct ip_vs_mh_state *s,
>               return 0;
>       }
>  
> -     table = kcalloc(BITS_TO_LONGS(IP_VS_MH_TAB_SIZE),
> -                     sizeof(unsigned long), GFP_KERNEL);
> +     table = bitmap_zalloc(IP_VS_MH_TAB_SIZE, GFP_KERNEL);
>       if (!table)
>               return -ENOMEM;
>  
> @@ -227,7 +226,7 @@ static int ip_vs_mh_populate(struct ip_vs_mh_state *s,
>       }
>  
>  out:
> -     kfree(table);
> +     bitmap_free(table);
>       return 0;
>  }
>  
> -- 
> 2.34.1

Regards

--
Julian Anastasov <ja@xxxxxx>