LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH-next v2 0/2] ipvs: Fix incorrect use of HK_TYPE_KTHREAD house

To: Waiman Long <longman@xxxxxxxxxx>
Subject: Re: [PATCH-next v2 0/2] ipvs: Fix incorrect use of HK_TYPE_KTHREAD housekeeping cpumask
Cc: Simon Horman <horms@xxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, David Ahern <dsahern@xxxxxxxxxx>, Eric Dumazet <edumazet@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>, Florian Westphal <fw@xxxxxxxxx>, Phil Sutter <phil@xxxxxx>, Frederic Weisbecker <frederic@xxxxxxxxxx>, Chen Ridong <chenridong@xxxxxxxxxx>, Phil Auld <pauld@xxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx, sheviks <sheviks@xxxxxxxxx>
From: Julian Anastasov <ja@xxxxxx>
Date: Fri, 3 Apr 2026 17:15:50 +0300 (EEST)
        Hello,

On Tue, 31 Mar 2026, Waiman Long wrote:

>  v2:
>   - Rebased on top of linux-next
> 
> Since commit 041ee6f3727a ("kthread: Rely on HK_TYPE_DOMAIN for preferred
> affinity management"), the HK_TYPE_KTHREAD housekeeping cpumask may no
> longer be correct in showing the actual CPU affinity of kthreads that
> have no predefined CPU affinity. As the ipvs networking code is still
> using HK_TYPE_KTHREAD, we need to make HK_TYPE_KTHREAD reflect the
> reality.
> 
> This patch series makes HK_TYPE_KTHREAD an alias of HK_TYPE_DOMAIN
> and uses RCU to protect access to the HK_TYPE_KTHREAD housekeeping
> cpumask.
> 
> Waiman Long (2):
>   sched/isolation: Make HK_TYPE_KTHREAD an alias of HK_TYPE_DOMAIN
>   ipvs: Guard access of HK_TYPE_KTHREAD cpumask with RCU

        The patchset looks good to me for nf-next, thanks!

Acked-by: Julian Anastasov <ja@xxxxxx>

        Pablo, Florian, as a bugfix this patchset missed
the chance to be applied before the changes that are in
nf-next in ip_vs.h, there is little fuzz there. If there
is no chance to resolve it somehow, we can apply it
on top of nf-next where it now applies successfully.

> 
>  include/linux/sched/isolation.h |  6 +++++-
>  include/net/ip_vs.h             | 20 ++++++++++++++++----
>  net/netfilter/ipvs/ip_vs_ctl.c  | 13 ++++++++-----
>  3 files changed, 29 insertions(+), 10 deletions(-)

Regards

--
Julian Anastasov <ja@xxxxxx>



<Prev in Thread] Current Thread [Next in Thread>