LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH] ipvs: Fix checksumming on GSO of SCTP packets

To: Ismael Luceno <iluceno@xxxxxxx>
Subject: Re: [PATCH] ipvs: Fix checksumming on GSO of SCTP packets
Cc: linux-kernel@xxxxxxxxxxxxxxx, Firo Yang <firo.yang@xxxxxxxx>, Andreas Taschner <andreas.taschner@xxxxxxxx>, Michal Kubeček <mkubecek@xxxxxxxx>, Simon Horman <horms@xxxxxxxxxxxx>, lvs-devel@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx
From: Julian Anastasov <ja@xxxxxx>
Date: Sun, 21 Apr 2024 18:58:11 +0300 (EEST)
        Hello,

On Sun, 21 Apr 2024, Ismael Luceno wrote:

> On 21/Apr/2024 14:01, Julian Anastasov wrote:
> 
> >     I'm guessing what should be the Fixes line, may be?:
> > 
> > Fixes: 90017accff61 ("sctp: Add GSO support")
> 
> This seems like the right one.
> 
> >     because SCTP GSO was added after the IPVS code? Or the
> > more recent commit d02f51cbcf12 which adds skb_is_gso_sctp ?
> 
> That doesn't seem related at all.
> 
> Do we need to check .gso_type in cases like this?

        Just skb_is_gso(skb) ? IMHO, this should work.

Regards

--
Julian Anastasov <ja@xxxxxx>



<Prev in Thread] Current Thread [Next in Thread>