![]() |
lvs-devel
|
| To: | Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH net v3] ipvs: fix MTU check for GSO packets in tunnel mode |
| Cc: | Yingnan Zhang <342144303@xxxxxx>, horms@xxxxxxxxxxxx, fw@xxxxxxxxx, phil@xxxxxx, davem@xxxxxxxxxxxxx, edumazet@xxxxxxxxxx, kuba@xxxxxxxxxx, pabeni@xxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx |
| From: | Julian Anastasov <ja@xxxxxx> |
| Date: | Fri, 10 Apr 2026 09:51:31 +0300 (EEST) |
Hello,
On Fri, 10 Apr 2026, Pablo Neira Ayuso wrote:
> On Thu, Apr 02, 2026 at 10:46:16PM +0800, Yingnan Zhang wrote:
> > + } else if (skb->len > mtu &&
> > + !(skb_is_gso(skb) && skb_gso_validate_network_len(skb,
> > mtu))) {
>
> Maybe helper function helps make this more readable?
>
> /* Based on ip_exceeds_mtu(). */
> static bool ip_vs_exceeds_mtu(const struct sk_buff *skb, unsigned int mtu)
> {
> if (skb->len <= mtu)
> return false;
>
> if (skb_is_gso(skb) && skb_gso_validate_network_len(skb, mtu))
> return false;
>
> return true;
> }
Good idea! Yingnan Zhang, please send v4 by adding
this new function before __mtu_check_toobig_v6()...
Regards
--
Julian Anastasov <ja@xxxxxx>
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH net v3] ipvs: fix MTU check for GSO packets in tunnel mode, Pablo Neira Ayuso |
|---|---|
| Next by Date: | [syzbot] [lvs?] BUG: sleeping function called from invalid context in ip_vs_conn_expire, syzbot |
| Previous by Thread: | Re: [PATCH net v3] ipvs: fix MTU check for GSO packets in tunnel mode, Pablo Neira Ayuso |
| Next by Thread: | Re: [PATCH-next v2 0/2] ipvs: Fix incorrect use of HK_TYPE_KTHREAD housekeeping cpumask, Julian Anastasov |
| Indexes: | [Date] [Thread] [Top] [All Lists] |