Mail Archive Search: <+subject:/^(?:^\s*(re|sv|fwd|fw)[\[\]\d]*[:>-]+\s*)*\[PATCH\]\s+ipvs\:\s+initialize\s+\'ret\'\s+variable\s+in\s+do_ip_vs_set

Results:

References: [ +subject:/^(?:^\s*(re|sv|fwd|fw)[\[\]\d]*[:>-]+\s*)*\[PATCH\]\s+ipvs\:\s+initialize\s+\'ret\'\s+variable\s+in\s+do_ip_vs_set_ctl\s*$/: 7 ]

Total 7 documents matching your query.

1. Re: [PATCH] ipvs: initialize 'ret' variable in do_ip_vs_set_ctl() (score: 1): Author: liqiong <liqiong@xxxxxxxxxxxx>; Date: Mon, 12 Dec 2022 15:05:30 +0800; 20221202 19:26, Julian Anastasov : Thanks, I will send a v2 patch.; /html/lvs-devel/2022-12/msg00011.html (13,746 bytes)
2. Re: [PATCH] ipvs: initialize 'ret' variable in do_ip_vs_set_ctl() (score: 1): Author: Julian Anastasov <ja@xxxxxx>; Date: Fri, 2 Dec 2022 13:26:26 +0200 (EET); Hello, Yes, no bug in current code. But it is better to return the default switch case with -EINVAL (not 0), in case new commands are added. Such patch should target net-next, it is just for compiler; /html/lvs-devel/2022-12/msg00005.html (12,581 bytes)
3. Re: [PATCH] ipvs: initialize 'ret' variable in do_ip_vs_set_ctl() (score: 1): Author: Dan Carpenter <error27@xxxxxxxxx>; Date: Fri, 2 Dec 2022 13:26:03 +0300; Yeah. If it is a false positive just ignore it, do not bother to silence wrong static checker warnings. The code in question here is: if (len != set_arglen[CMDID(cmd)]) { The only time that condition; /html/lvs-devel/2022-12/msg00004.html (12,283 bytes)
4. Re: [PATCH] ipvs: initialize 'ret' variable in do_ip_vs_set_ctl() (score: 1): Author: liqiong <liqiong@xxxxxxxxxxxx>; Date: Fri, 2 Dec 2022 18:18:37 +0800; 20221202 18:07, Dan Carpenter : It is not a real bug, I use tool (eg: smatch, sparse) to audit the code, got this warning and check it, found may be a real problem.; /html/lvs-devel/2022-12/msg00003.html (12,076 bytes)
5. Re: [PATCH] ipvs: initialize 'ret' variable in do_ip_vs_set_ctl() (score: 1): Author: Dan Carpenter <error27@xxxxxxxxx>; Date: Fri, 2 Dec 2022 13:07:02 +0300; If this is a real bug, then it needs a fixes tag. The fixes tag helps us know whether to back port or not and it also helps in reviewing the patch. Also get_maintainer.pl will CC the person who intro; /html/lvs-devel/2022-12/msg00002.html (11,469 bytes)
6. Re: [PATCH] ipvs: initialize 'ret' variable in do_ip_vs_set_ctl() (score: 1): Author: Simon Horman <horms@xxxxxxxxxxxx>; Date: Fri, 2 Dec 2022 11:02:04 +0100; Thanks, I agree there seems to be a problem here. But perhaps it's nicer to solve it by adding a default case to the switch statement? Also, if we update the declaration of ret, perhaps we could also; /html/lvs-devel/2022-12/msg00001.html (11,944 bytes)
7. [PATCH] ipvs: initialize 'ret' variable in do_ip_vs_set_ctl() (score: 1): Author: Li Qiong <liqiong@xxxxxxxxxxxx>; Date: Fri, 2 Dec 2022 11:25:11 +0800; The 'ret' should need to be initialized to 0, in case return a uninitialized value because no default process for "switch (cmd)". Signed-off-by: Li Qiong <liqiong@xxxxxxxxxxxx> -- net/netfilter/ipvs/; /html/lvs-devel/2022-12/msg00000.html (9,524 bytes)

Current List: 1 - 7
Page: [1]