Hello, Use goto cleanup instead of return ret; You have to call ip_vs_protocol_net_cleanup(net) here because if ip_vs_protocol_net_init fails it is not called. Your change is not enough. To avoid com
Hello, Simon, I'm sending 2 patches for this ftp problem in separate thread. Please, test if the problem is solved. Regards -- Julian Anastasov <ja@xxxxxx> -- To unsubscribe from this list: send the
Author: Hans Schillstrom <hans.schillstrom@xxxxxxxxxxxx>
Date: Fri, 13 Apr 2012 10:03:41 +0200
Hello Simon and Sasha Sorry for not helping been quite busy for a while I think Pablo was touching the root cause, There is a generic fault in the patch, you must take care of un_register of the prot
[sni@] I have confirmed that the cleanup code is called on error, so I think that your existing patch is fine. Acked-by: Simon Horman <horms@xxxxxxxxxxxx> Pablo, please consider taking this change. T
Good point. In any case, I think that I have found a new problem. With your proposed patch in place I see a panic in ftp helper registration in the case where protocol registration fails. I have not
I thought that the cleanup callback is getting called for failed init calls, if that's not the case then we can probably call it ourselves if any of these failed. -- To unsubscribe from this list: se
Thanks Pablo, I was thinking along those lines too. I'll send an updated patch. -- To unsubscribe from this list: send the line "unsubscribe lvs-devel" in the body of a message to majordomo@xxxxxxxxx
^^^ sorry, I meant to say udp here. ^^^ and here. -- To unsubscribe from this list: send the line "unsubscribe lvs-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at
If you return here, I think you'll leave things in inconsistent state, ie. the tcp protocol is registered. You have to unregister it before leaving. ret = register_ip_vs_proto_netns(net, &ip_vs_proto
The scenario is a failed allocation in register_ip_vs_proto_netns(), which can happen in real world cases as well. -- To unsubscribe from this list: send the line "unsubscribe lvs-devel" in the body
Hello Simon I don't think this is a big thing, the only thing that can cause it is out of memory, and that will cause a "kernel death" anyway :-( here is the code : register_ip_vs_proto_netns(struct
Thanks, I will queue up this fix. Do you have a real-world example of this failing, if so it might be worth pushing your change into stable. -- To unsubscribe from this list: send the line "unsubscri
The registration of a protocol might fail, there were no checks and all registrations were assumed to be correct. This lead to NULL ptr dereferences when apps tried registering. For example: [ 1293.2