Search String: Display: Description: Sort:

Results:

References: [ +subject:/^(?:^\s*(re|sv|fwd|fw)[\[\]\d]*[:>-]+\s*)*\[PATCH\]\s+netfilter\:\s+ipvs\:\s+Verify\s+that\s+IP_VS\s+protocol\s+has\s+been\s+registered\s*$/: 13 ]

Total 13 documents matching your query.

1. Re: [PATCH] netfilter: ipvs: Verify that IP_VS protocol has been registered (score: 1)
Author: Julian Anastasov <ja@xxxxxx>
Date: Sat, 14 Apr 2012 00:13:22 +0300 (EEST)
Hello, Use goto cleanup instead of return ret; You have to call ip_vs_protocol_net_cleanup(net) here because if ip_vs_protocol_net_init fails it is not called. Your change is not enough. To avoid com
/html/lvs-devel/2012-04/msg00044.html (18,452 bytes)

2. Re: [PATCH] netfilter: ipvs: Verify that IP_VS protocol has been registered (score: 1)
Author: Julian Anastasov <ja@xxxxxx>
Date: Fri, 13 Apr 2012 11:35:55 +0300 (EEST)
Hello, Simon, I'm sending 2 patches for this ftp problem in separate thread. Please, test if the problem is solved. Regards -- Julian Anastasov <ja@xxxxxx> -- To unsubscribe from this list: send the
/html/lvs-devel/2012-04/msg00025.html (12,999 bytes)

3. Re: [PATCH] netfilter: ipvs: Verify that IP_VS protocol has been registered (score: 1)
Author: Hans Schillstrom <hans.schillstrom@xxxxxxxxxxxx>
Date: Fri, 13 Apr 2012 10:03:41 +0200
Hello Simon and Sasha Sorry for not helping been quite busy for a while I think Pablo was touching the root cause, There is a generic fault in the patch, you must take care of un_register of the prot
/html/lvs-devel/2012-04/msg00024.html (18,171 bytes)

4. Re: [PATCH] netfilter: ipvs: Verify that IP_VS protocol has been registered (score: 1)
Author: Simon Horman <horms@xxxxxxxxxxxx>
Date: Fri, 13 Apr 2012 15:22:50 +0900
[sni@] I have confirmed that the cleanup code is called on error, so I think that your existing patch is fine. Acked-by: Simon Horman <horms@xxxxxxxxxxxx> Pablo, please consider taking this change. T
/html/lvs-devel/2012-04/msg00023.html (11,947 bytes)

5. Re: [PATCH] netfilter: ipvs: Verify that IP_VS protocol has been registered (score: 1)
Author: Simon Horman <horms@xxxxxxxxxxxx>
Date: Fri, 13 Apr 2012 13:11:50 +0900
Good point. In any case, I think that I have found a new problem. With your proposed patch in place I see a panic in ftp helper registration in the case where protocol registration fails. I have not
/html/lvs-devel/2012-04/msg00022.html (14,469 bytes)

6. Re: [PATCH] netfilter: ipvs: Verify that IP_VS protocol has been registered (score: 1)
Author: Sasha Levin <levinsasha928@xxxxxxxxx>
Date: Fri, 13 Apr 2012 02:54:13 +0200
I thought that the cleanup callback is getting called for failed init calls, if that's not the case then we can probably call it ourselves if any of these failed. -- To unsubscribe from this list: se
/html/lvs-devel/2012-04/msg00021.html (10,859 bytes)

7. Re: [PATCH] netfilter: ipvs: Verify that IP_VS protocol has been registered (score: 1)
Author: Simon Horman <horms@xxxxxxxxxxxx>
Date: Fri, 13 Apr 2012 06:41:28 +0900
Thanks Pablo, I was thinking along those lines too. I'll send an updated patch. -- To unsubscribe from this list: send the line "unsubscribe lvs-devel" in the body of a message to majordomo@xxxxxxxxx
/html/lvs-devel/2012-04/msg00020.html (17,447 bytes)

8. Re: [PATCH] netfilter: ipvs: Verify that IP_VS protocol has been registered (score: 1)
Author: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
Date: Thu, 12 Apr 2012 01:46:28 +0200
^^^ sorry, I meant to say udp here. ^^^ and here. -- To unsubscribe from this list: send the line "unsubscribe lvs-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at
/html/lvs-devel/2012-04/msg00018.html (16,472 bytes)

9. Re: [PATCH] netfilter: ipvs: Verify that IP_VS protocol has been registered (score: 1)
Author: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
Date: Thu, 12 Apr 2012 01:22:43 +0200
If you return here, I think you'll leave things in inconsistent state, ie. the tcp protocol is registered. You have to unregister it before leaving. ret = register_ip_vs_proto_netns(net, &ip_vs_proto
/html/lvs-devel/2012-04/msg00017.html (15,864 bytes)

10. Re: [PATCH] netfilter: ipvs: Verify that IP_VS protocol has been registered (score: 1)
Author: Sasha Levin <levinsasha928@xxxxxxxxx>
Date: Fri, 6 Apr 2012 11:07:21 +0200
The scenario is a failed allocation in register_ip_vs_proto_netns(), which can happen in real world cases as well. -- To unsubscribe from this list: send the line "unsubscribe lvs-devel" in the body
/html/lvs-devel/2012-04/msg00010.html (10,614 bytes)

11. Re[2]: [PATCH] netfilter: ipvs: Verify that IP_VS protocol has been registered (score: 1)
Author: "Hans Schillstrom" <hans@xxxxxxxxxxxxxxx>
Date: Fri, 6 Apr 2012 10:59:23 +0200 (CEST)
Hello Simon I don't think this is a big thing, the only thing that can cause it is out of memory, and that will cause a "kernel death" anyway :-( here is the code : register_ip_vs_proto_netns(struct
/html/lvs-devel/2012-04/msg00009.html (11,530 bytes)

12. Re: [PATCH] netfilter: ipvs: Verify that IP_VS protocol has been registered (score: 1)
Author: Simon Horman <horms@xxxxxxxxxxxx>
Date: Fri, 6 Apr 2012 08:19:42 +0900
Thanks, I will queue up this fix. Do you have a real-world example of this failing, if so it might be worth pushing your change into stable. -- To unsubscribe from this list: send the line "unsubscri
/html/lvs-devel/2012-04/msg00008.html (9,484 bytes)

13. [PATCH] netfilter: ipvs: Verify that IP_VS protocol has been registered (score: 1)
Author: Sasha Levin <levinsasha928@xxxxxxxxx>
Date: Thu, 5 Apr 2012 19:24:33 -0400
The registration of a protocol might fail, there were no checks and all registrations were assumed to be correct. This lead to NULL ptr dereferences when apps tried registering. For example: [ 1293.2
/html/lvs-devel/2012-04/msg00007.html (13,830 bytes)


This search system is powered by Namazu