[cut] (small correction ipv6_find_hdr() is not that costly for the general case of no exthdrs) This passing the "struct ip_vs_iphdr" actually makes sense. It reminds me of the way netfilter/iptables
[...cut...] [...cut...] I've been looking at the code for ip6t_do_table() and it already calls ipv6_find_hdr(). ip6t_do_table() calls ip6_packet_match() And ip6_packet_match() already calls ipv6_find
To Patrick, How about we change netfilter to set up the skb's transport header at an early time so we can avoid all (most of) these header scans in netfilter? I think that would be great, maybe it s
To Patrick, Okay, but then I do need some help and guidance, especially from Patrick, think. First of all, where in the netfilter code, should we update the new fields in inet6_skb_parm? -- To unsubs
Based on patch from: Hans Schillstrom IPv6 headers must be processed in order of appearance, neither can it be assumed that Upper layer headers is first. If anything else than L4 is the first header
I guess that's the problem, adding it to the skb will not be popular .... Right now I don't have a good solution, maybe a more generic netfilter ptr in the skb ... -- To unsubscribe from this list:
Based on patch from: Hans Schillstrom IPv6 headers must be processed in order of appearance, neither can it be assumed that Upper layer headers is first. If anything else than L4 is the first header
I think that would be great, maybe it should be global i.e. not only a netfilter issue. -- To unsubscribe from this list: send the line "unsubscribe lvs-devel" in the body of a message to majordomo@
Based on patch from: Hans Schillstrom IPv6 headers must be processed in order of appearance, neither can it be assumed that Upper layer headers is first. If anything else than L4 is the first header
Hello, The way you prefer. We can fix it after this patchset. For example: ciph = (struct ip_vs_iphdr) { .len = iph->len + sizeof(_icmph), .saddr = iph->saddr, .daddr = iph->daddr, }; ciph.protocol =
Okay. Wondering if we should keep these cleanup changes to a separate patch. Good catch, I'll re-add the NULL pointer check. (notice that &ciph.len can get updated by ipv6_find_hdr()) I'm not sure I
Hello, Patch 1 looks ok, following are some small comments for patch 2 and 3. There is already #if IS_ENABLED(CONFIG_IPV6) that can replace #if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE) It
Based on patch from: Hans Schillstrom IPv6 headers must be processed in order of appearance, neither can it be assumed that Upper layer headers is first. If anything else than L4 is the first header