I have no strong opinion about removing rt6_nexthop. If it is of low cost today and makes the code easier to undersand and grep, just leave it alone. -- To unsubscribe from this list: send the line "
Hello, Thanks for the review! I don't mind too about removing rt6_nexthop. For me it is 51% against 49% to keep it as it denotes the places that use nexthop and not gateway. May be more opinions will
Author: Hannes Frederic Sowa <hannes@xxxxxxxxxxxxxxxxxxx>
Date: Mon, 21 Oct 2013 07:01:59 +0200
The patch is fine. I don't mind if we leave it as is or remove rt6_nexthop, so: Acked-by: Hannes Frederic Sowa <hannes@xxxxxxxxxxxxxxxxxxx> Thanks, Hannes -- To unsubscribe from this list: send the l
Author: Hannes Frederic Sowa <hannes@xxxxxxxxxxxxxxxxxxx>
Date: Sun, 20 Oct 2013 20:33:04 +0200
Hm, looks good. Will test is soon. One small remark: Maybe we can kill rt6_nexthop completly and use rt6i_gateway directly so a reader does not have to lookup this function. Thanks, Hannes -- To unsu
Make sure rt6i_gateway contains nexthop information in all routes returned from lookup or when routes are directly attached to skb for generated ICMP packets. The effect of this patch should be a fas