LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH] IPVS: Move userspace definitions to include/linux/ip_vs.h

To: "Patrick McHardy" <kaber@xxxxxxxxx>
Subject: Re: [PATCH] IPVS: Move userspace definitions to include/linux/ip_vs.h
Cc: "Simon Horman" <horms@xxxxxxxxxxxx>, lvs-devel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, davem@xxxxxxxxxxxxx, vbusam@xxxxxxxxxx
From: "Julius Volz" <juliusv@xxxxxxxxxx>
Date: Thu, 24 Jul 2008 13:46:38 +0200
On Thu, Jul 24, 2008 at 1:40 PM, Patrick McHardy <kaber@xxxxxxxxx> wrote:
> Julius Volz wrote:
>>
>> On Thu, Jul 24, 2008 at 1:22 PM, Patrick McHardy <kaber@xxxxxxxxx> wrote:
>>>>>
>>>>> +/* Move it to better place one day, for now keep it unique */
>>>>> +#define NFC_IPVS_PROPERTY      0x10000
>>>
>>> Does this have any connection to the skb flag? If so, does
>>> it really belong in the userspace interface?
>>
>> This doesn't seem to be used at all anymore, but I didn't want to
>> remove it in the same patch... should I?
>
> I'm not sure if this is (or has been) used by userspace, someone
> more familiar with IPVS should answer that.

I don't think so. It was once used as a bitmask into skb->nfcache,
which does not even exist anymore. There's no use of it in the current
ipvsadm. I think it can go away, I'll post an updated patch again.

Julius

-- 
Google Switzerland GmbH
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>