Re: [PATCH] ipvs: Create init functions for estimator code

To:	Sven Wegener <sven.wegener@xxxxxxxxxxx>
Subject:	Re: [PATCH] ipvs: Create init functions for estimator code
Cc:	netdev@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, wensong@xxxxxxxxxxxx, ja@xxxxxx
From:	Simon Horman <horms@xxxxxxxxxxxx>
Date:	Thu, 14 Aug 2008 14:52:02 +1000

On Thu, Aug 14, 2008 at 12:47:16AM +0200, Sven Wegener wrote:
> Commit 8ab19ea36c5c5340ff598e4d15fc084eb65671dc ("ipvs: Fix possible deadlock
> in estimator code") fixed a deadlock condition, but that condition can only
> happen during unload of IPVS, because during normal operation there is at 
> least
> our global stats structure in the estimator list. The mod_timer() and
> del_timer_sync() calls are actually initialization and cleanup code in
> disguise. Let's make it explicit and move them to their own init and cleanup
> function.
> 
> Signed-off-by: Sven Wegener <sven.wegener@xxxxxxxxxxx>

I like the simplification that this change brings.

Acked-by: Simon Horman <horms@xxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH] ipvs: Create init functions for estimator code, Sven Wegener Re: [PATCH] ipvs: Create init functions for estimator code, Simon Horman <=

Previous by Date:	Re: [PATCH] ipvs: Only call init_service, update_service and done_service for schedulers if defined, Simon Horman
Next by Date:	Re: [PATCH] ipvs: Only call init_service, update_service and done_service for schedulers if defined, Sven Wegener
Previous by Thread:	[PATCH] ipvs: Create init functions for estimator code, Sven Wegener
Next by Thread:	[PATCH] ipvs: Fix race conditions in lblc scheduler, Sven Wegener
Indexes:	[Date] [Thread] [Top] [All Lists]