LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH 2/2] ipvs: load balance ipv6 connections from a local process

To: "Brian Haley" <brian.haley@xxxxxx>
Subject: Re: [PATCH 2/2] ipvs: load balance ipv6 connections from a local process
Cc: "Simon Horman" <horms@xxxxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, "Malcolm Turnbull" <malcolm@xxxxxxxxxxxxxxxx>, "Siim Põder" <siim@xxxxxxxxxxxxxxx>, "Vince Busam" <vbusam@xxxxxxxxxx>
From: "Julius Volz" <juliusv@xxxxxxxxxx>
Date: Fri, 5 Sep 2008 18:37:28 +0200
On Fri, Sep 5, 2008 at 5:55 PM, Brian Haley <brian.haley@xxxxxx> wrote:
> Julius Volz wrote:
>>>
>>> -out:
>>> -       __ip_vs_conn_put(cp);
>>> -
>>> -       return verdict;
>>> +       snet.in6 = iph->saddr;
>>
>> I've always been told to use ipv6_addr_copy() for this. I'm not sure
>> what the problem with the direct struct assignment is though... would
>> be nice if someone could explain.
>
> Because an in6_addr is a union of 4 u32's, which won't all be copied in a
> struct assignment.  That's the way I've always understood it.

No, they _do_ all get copied and the result seems correct. There must
be another reason...

Julius

-- 
Julius Volz - Corporate Operations - SysOps

Google Switzerland GmbH - Identification No.: CH-020.4.028.116-1
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>