LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH] ipvs: Use pointer to address from sync message

To: Julius Volz <juliusv@xxxxxxxxxx>
Subject: Re: [PATCH] ipvs: Use pointer to address from sync message
Cc: Sven Wegener <sven.wegener@xxxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, kaber@xxxxxxxxx, vbusam@xxxxxxxxxx
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Sat, 6 Sep 2008 14:26:11 +1000
On Fri, Sep 05, 2008 at 02:28:48PM +0200, Julius Volz wrote:
> On Fri, Sep 5, 2008 at 1:46 PM, Sven Wegener <sven.wegener@xxxxxxxxxxx> wrote:
> > We want a pointer to it, not the value casted to a pointer.
> 
> Ouch, right!
> 
> > Signed-off-by: Sven Wegener <sven.wegener@xxxxxxxxxxx>
> > ---
> >  net/ipv4/ipvs/ip_vs_sync.c |    6 +++---
> >  1 files changed, 3 insertions(+), 3 deletions(-)
> >
> > I've been too late with having a look at these patches. I'm going to
> > send follow-up patches for the issues I find.

Sven, as always thanks very much for your patches.

> Thanks! There are probably still lots of these easy-to-miss (but bad)
> bugs in this big new bunch of code...
> 
> > Simon, please apply onto lvs-next-2.6.
> 
> Yes!

Julius, can I take that as an Acked-by for the follwing changes?

[PATCH] ipvs: Use pointer to address from sync message
[PATCH] ipvs: Return negative error values from
[PATCH] ipvs: Mark tcp/udp v4 and v6 debug functions static
[PATCH] ipvs: Reject ipv6 link-local addresses for destinations

--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>