Re: [rfc 1/3] ipvs: handle PARTIAL_CHECKSUM

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Mon, Sep 08, 2008 at 12:04:21PM +1000, Simon Horman wrote:
>
>       /* Adjust TCP checksums */
> -     if (!cp->app && (tcph->check != 0)) {
> +     if (skb->ip_summed == CHECKSUM_PARTIAL) {
> +             tcp_partial_csum_update(cp->af, tcph, &cp->daddr, &cp->vaddr,
> +                                     htonl(oldlen),
> +                                     htonl(skb->len - tcphoff));

I don't know what cp->app is but should we be updating the checksum
when it's set? The previous code seems to want to compute a full
checksum instead.

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html