Re: [PATCH 1/2] IPVS: use pr_fmt

[Joe Perches <joe@xxxxxxxxxxx>]

On Tue, 2009-07-28 at 18:06 +0200, Hannes Eder wrote:
> While being at it cleanup whitespace.
> diff --git a/include/net/ip_vs.h b/include/net/ip_vs.h
> index e01cc2d..99f09ab 100644
> --- a/include/net/ip_vs.h
> +++ b/include/net/ip_vs.h
> @@ -99,47 +99,47 @@ static inline const char *ip_vs_dbg_addr(int af, char 
> *buf, size_t buf_len,
>       return &buf[*idx - len];
>  }
>  
> -#define IP_VS_DBG_BUF(level, msg...)                 \
> -    do {                                             \
> -         char ip_vs_dbg_buf[160];                    \
> -         int ip_vs_dbg_idx = 0;                      \
> -         if (level <= ip_vs_get_debug_level())       \
> -                 printk(KERN_DEBUG "IPVS: " msg);    \
> -    } while (0)
[]
> +#define IP_VS_DBG_BUF(level, msg...)                         \
> +     do {                                                    \
> +             char ip_vs_dbg_buf[160];                        \
> +             int ip_vs_dbg_idx = 0;                          \
> +             if (level <= ip_vs_get_debug_level())           \
> +                     pr_debug(msg);                          \

I think you should keep printk(KERN_DEBUG...) here and elsewhere.
Unless DEBUG is #defined, this won't print anything.


--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html