Re: [PATCH] ipvs: Add boundary check on ioctl arguments

To: Patrick McHardy <kaber@xxxxxxxxx>
Subject: Re: [PATCH] ipvs: Add boundary check on ioctl arguments
Cc: Simon Horman <horms@xxxxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, Wensong Zhang <wensong@xxxxxxxxxxxx>, Julian Anastasov <ja@xxxxxx>, David Miller <davem@xxxxxxxxxxxxx>
From: Arjan van de Ven <arjan@xxxxxxxxxxxxxxx>
Date: Mon, 04 Jan 2010 07:34:33 -0800
On 1/4/2010 5:59, Patrick McHardy wrote:

[sorry for the late response, just got back from a good holiday, which means no 
work email access ;-) ]

Simon Horman wrote:

I agree with Julian's assessment that your patch shouldn't be
necessary, but on the other hand I think that the checks are
reasonable. Your original patch made checks of the form of
"cmd>  IP_VS_SO_GET_MAX + 1". I have updated this to
"cmd>  IP_VS_SO_GET_MAX", as suggested by Julian, as the optmax
elements of struct nf_sockopt_ops set a non-inclusive range.

Index: net-next-2.6/net/netfilter/ipvs/ip_vs_ctl.c

As a bugfix, this seems more appropriate for net-2.6.git. Please let
me know which tree you want me to apply this to.

this really ought to go into 2.6.33.....
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at

<Prev in Thread] Current Thread [Next in Thread>