|
Thank you for picking this series of patches up again and thanks for
the feedback.
I'll send an updated version in the next days.
Cheers, -Hannes
On Sat, May 1, 2010 at 18:18, Patrick McHardy <kaber@xxxxxxxxx> wrote:
> Simon Horman wrote:
>
>> @@ -0,0 +1,25 @@
>> +#ifndef _XT_IPVS_H
>> +#define _XT_IPVS_H 1
>
> You don't need to define a value.
>
>> +config NETFILTER_XT_MATCH_IPVS
>> + tristate '"ipvs" match support'
>> + depends on IP_VS
>> + depends on NETFILTER_ADVANCED
>> + help
>> + This option allows you to match against IPVS properties of a packet.
>> +
>> + If unsure, say N.
>
> You're using conntrack symbols, so this seems to need a dependency
> on NF_CONNTRACK.
>
>> +static bool ipvs_mt_check(const struct xt_mtchk_param *par)
>
> We've changed the signature to "int" in nf-next to be able to
> return errno codes. Please rebase your patches onto nf-next-2.6.git.
>
> Please also CC netfilter-devel at least for those parts that affect
> non-IPVS netfilter.
>
>> +{
>> + if (par->family != NFPROTO_IPV4
>> +#ifdef CONFIG_IP_VS_IPV6
>> + && par->family != NFPROTO_IPV6
>> +#endif
>> + ) {
>> + pr_info("protocol family %u not supported\n", par->family);
>> + return false;
>> + }
>> +
>> + return true;
>> +}
>
>
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
|
