Re: [patch v2.3 3/4] IPVS: make FTP work with full NAT support

To: Simon Horman <horms@xxxxxxxxxxxx>
Subject: Re: [patch v2.3 3/4] IPVS: make FTP work with full NAT support
Cc: lvs-devel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netfilter@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, Malcolm Turnbull <malcolm@xxxxxxxxxxxxxxxx>, Wensong Zhang <wensong@xxxxxxxxxxxx>, Julius Volz <julius.volz@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Hannes Eder <heder@xxxxxxxxxx>
From: Patrick McHardy <kaber@xxxxxxxxx>
Date: Tue, 06 Jul 2010 13:43:44 +0200
Simon Horman wrote:
@@ -219,19 +358,23 @@ static int ip_vs_ftp_out(struct ip_vs_ap
buf_len = strlen(buf); + ct = nf_ct_get(skb, &ctinfo);
+               ret = nf_nat_mangle_tcp_packet(skb,
+                                              ct,
+                                              ctinfo,
+                                              start-data,
+                                              end-start,
+                                              buf,
+                                              buf_len);
+               if (ct && ct != &nf_conntrack_untracked)
This does not make sense, you're already using the conntrack above
in the call to nf_nat_mangle_tcp_packet(), so the check should
probably happen before that. You also should be checking the
return value of nf_nat_mangle_tcp_packet() before setting up the

+                       ip_vs_expect_related(skb, ct, n_cp,
+                                            IPPROTO_TCP, NULL, 0);

To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at

<Prev in Thread] Current Thread [Next in Thread>