LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH] lvs sctp protocol handler is incorrectly invoked ip_vs_app_p

To: xiaoyu Du <tingsrain@xxxxxxxxx>
Subject: Re: [PATCH] lvs sctp protocol handler is incorrectly invoked ip_vs_app_pkt_out
Cc: linux-kernel@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, wensong@xxxxxxxxxxxx, NetDev <netdev@xxxxxxxxxxxxxxx>, Patrick McHardy <kaber@xxxxxxxxx>
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Thu, 8 Jul 2010 21:13:19 +0900
On Thu, Jul 08, 2010 at 09:55:04AM +0800, xiaoyu Du wrote:
> lvs sctp protocol handler is incorrectly invoked ip_vs_app_pkt_out
> Since there's no sctp helpers at present, it does the same thing as
> ip_vs_app_pkt_in.
> 
> Signed-off-by: Xiaoyu Du <tingsrain@xxxxxxxxx>

Thanks Xiaoyu.

Acked-by: Simon Horman <horms@xxxxxxxxxxxx>

Patrick, please consider applying this.
nf-next should be sufficient, as according
to Xiaoyu there aren't actually helpers
that exercise this code at the moment.

> ---
>  net/netfilter/ipvs/ip_vs_proto_sctp.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/netfilter/ipvs/ip_vs_proto_sctp.c
> b/net/netfilter/ipvs/ip_vs_proto_sctp.c
> index c9a3f7a..db55759 100644
> --- a/net/netfilter/ipvs/ip_vs_proto_sctp.c
> +++ b/net/netfilter/ipvs/ip_vs_proto_sctp.c
> @@ -173,7 +173,7 @@ sctp_dnat_handler(struct sk_buff *skb,
>                       return 0;
> 
>               /* Call application helper if needed */
> -             if (!ip_vs_app_pkt_out(cp, skb))
> +             if (!ip_vs_app_pkt_in(cp, skb))
>                       return 0;
>       }
> 
> --
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>