LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [patch] ipvsadm: Don't report persistentconns as activeconns

To: lvs-devel <lvs-devel@xxxxxxxxxxxxxxx>
Subject: Re: [patch] ipvsadm: Don't report persistentconns as activeconns
Cc: Wensong Zhang <wensong@xxxxxxxxxxxx>, Nigel Kukard <nkukard@xxxxxxxx>
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Tue, 20 Jul 2010 17:10:58 +0900
On Mon, Feb 22, 2010 at 09:07:52AM +1100, Simon Horman wrote:
> This fixes what appears to be a typo in the netlink client code
> whereby the activeconns is read as activeconns and then
> overwritten by persistentconns. The result is that the active
> connection count reported by ipvsadm -L is wrong if the
> code is compiled to use the netlink interface.
> 
> Tested-by: Nigel Kukard <nkukard@xxxxxxxx>
> Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>
> 
> --- 
> 
> Wensong, please consider applying this patch to ipvsadm.

Wensong, Ping.

> Index: ipvsadm-1.25/libipvs/libipvs.c
> ===================================================================
> --- ipvsadm-1.25.orig/libipvs/libipvs.c       2010-02-18 16:57:46.000000000 
> +0900
> +++ ipvsadm-1.25/libipvs/libipvs.c    2010-02-18 16:57:49.000000000 +0900
> @@ -747,7 +747,7 @@ static int ipvs_dests_parse_cb(struct nl
>       d->entrytable[i].l_threshold = 
> nla_get_u32(dest_attrs[IPVS_DEST_ATTR_L_THRESH]);
>       d->entrytable[i].activeconns = 
> nla_get_u32(dest_attrs[IPVS_DEST_ATTR_ACTIVE_CONNS]);
>       d->entrytable[i].inactconns = 
> nla_get_u32(dest_attrs[IPVS_DEST_ATTR_INACT_CONNS]);
> -     d->entrytable[i].activeconns = 
> nla_get_u32(dest_attrs[IPVS_DEST_ATTR_PERSIST_CONNS]);
> +     d->entrytable[i].persistconns = 
> nla_get_u32(dest_attrs[IPVS_DEST_ATTR_PERSIST_CONNS]);
>       d->entrytable[i].af = d->af;
>  
>       if (ipvs_parse_stats(&(d->entrytable[i].stats),
> 
> --
> To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>