Re: [patch v2.6 4/4] libxt_ipvs: user-space lib for netfilter matcher xt_ipvs

[Simon Horman <horms@xxxxxxxxxxxx>]

On Wed, Jul 21, 2010 at 08:35:19AM +0200, Jan Engelhardt wrote:
> 
> On Wednesday 2010-07-21 03:21, Simon Horman wrote:
> >> +
> >> +#define XT_IPVS_IPVS_PROPERTY     (1 << 0) /* all other options imply 
> >> this one */
> >> +#define XT_IPVS_PROTO             (1 << 1)
> >> +#define XT_IPVS_VADDR             (1 << 2)
> >> +#define XT_IPVS_VPORT             (1 << 3)
> >> +#define XT_IPVS_DIR               (1 << 4)
> >> +#define XT_IPVS_METHOD            (1 << 5)
> >> +#define XT_IPVS_VPORTCTL  (1 << 6)
> >> +#define XT_IPVS_MASK              ((1 << 7) - 1)
> >> +#define XT_IPVS_ONCE_MASK (XT_IPVS_MASK & ~XT_IPVS_IPVS_PROPERTY)
> 
> Can't these just be an enum?

More than one option can be used at once - they form a mini bitmap -
so no, I don't think we can use an enum.

--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html