LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

[patch v2.8 1/4] netfilter: xt_ipvs (netfilter matcher for IPVS)

To: lvs-devel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netfilter@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx
Subject: [patch v2.8 1/4] netfilter: xt_ipvs (netfilter matcher for IPVS)
Cc: Malcolm Turnbull <malcolm@xxxxxxxxxxxxxxxx>, Mark Brooks <mark@xxxxxxxxxxxxxxxx>, Wensong Zhang <wensong@xxxxxxxxxxxx>, Julius Volz <julius.volz@xxxxxxxxx>, Patrick McHardy <kaber@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Hannes Eder <heder@xxxxxxxxxx>, Jan Engelhardt <jengelh@xxxxxxxxxx>
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Thu, 22 Jul 2010 16:35:48 +0900
From:   Hannes Eder <heder@xxxxxxxxxx>

This implements the kernel-space side of the netfilter matcher xt_ipvs.

[ minor fixes by Simon Horman <horms@xxxxxxxxxxxx> ]
Signed-off-by: Hannes Eder <heder@xxxxxxxxxx>
Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>

--- 

 include/linux/netfilter/xt_ipvs.h |   27 ++++
 net/netfilter/Kconfig             |   10 +
 net/netfilter/Makefile            |    1 
 net/netfilter/ipvs/ip_vs_proto.c  |    1 
 net/netfilter/xt_ipvs.c           |  189 +++++++++++++++++++++++++++++++++++++
 5 files changed, 228 insertions(+), 0 deletions(-)
 create mode 100644 include/linux/netfilter/xt_ipvs.h
 create mode 100644 net/netfilter/xt_ipvs.c

v2.8
* Trivial rediff
As suggested by Jan Engelhardt
* Use an enum instead of #ifdefs for flags and masks

v2.5
* Use nf_ct_is_untracked(ct) instead of ct == nf_ct_is_untracked(ct),
  the later is blatantly incorrect.

v2.4
As per advice from Patrick McHardy
* Reduce size of l4proto and fwd_method members of struct xt_ipvs_mtinf
  from __u16 to __u8
* Use nf_conntrack_untracked() instead of &nf_conntrack_untracked

v2.3
As per advice from Patrick McHardy
* Don't define a value for _XT_IPVS_H in xt_ipvs.h
* Depend on NF_CONNTRACK
* Update to new API
  - ipvs_mt_check() should return an int rather than a bool
  - Change type of ipvs_mt()'s par parameter from
    struct xt_action_param to struct xt_match_param
  - Make ipvs_mt()'s par parameter non-const

v2.1, v2.2
No Change
Index: nf-next-2.6/include/linux/netfilter/xt_ipvs.h
===================================================================
--- /dev/null   1970-01-01 00:00:00.000000000 +0000
+++ nf-next-2.6/include/linux/netfilter/xt_ipvs.h       2010-07-22 
10:39:44.000000000 +0900
@@ -0,0 +1,27 @@
+#ifndef _XT_IPVS_H
+#define _XT_IPVS_H
+
+enum {
+       XT_IPVS_IPVS_PROPERTY = 1 << 0, /* all other options imply this one */
+       XT_IPVS_PROTO =         1 << 1,
+       XT_IPVS_VADDR =         1 << 2,
+       XT_IPVS_VPORT =         1 << 3,
+       XT_IPVS_DIR =           1 << 4,
+       XT_IPVS_METHOD =        1 << 5,
+       XT_IPVS_VPORTCTL =      1 << 6,
+       XT_IPVS_MASK =          (1 << 7) - 1,
+       XT_IPVS_ONCE_MASK =     XT_IPVS_MASK & ~XT_IPVS_IPVS_PROPERTY
+};
+
+struct xt_ipvs_mtinfo {
+       union nf_inet_addr      vaddr, vmask;
+       __be16                  vport;
+       __u8                    l4proto;
+       __u8                    fwd_method;
+       __be16                  vportctl;
+
+       __u8                    invert;
+       __u8                    bitmask;
+};
+
+#endif /* _XT_IPVS_H */
Index: nf-next-2.6/net/netfilter/Kconfig
===================================================================
--- nf-next-2.6.orig/net/netfilter/Kconfig      2010-07-22 10:13:21.000000000 
+0900
+++ nf-next-2.6/net/netfilter/Kconfig   2010-07-22 10:13:42.000000000 +0900
@@ -742,6 +742,16 @@ config NETFILTER_XT_MATCH_IPRANGE
 
        If unsure, say M.
 
+config NETFILTER_XT_MATCH_IPVS
+       tristate '"ipvs" match support'
+       depends on IP_VS
+       depends on NETFILTER_ADVANCED
+       depends on NF_CONNTRACK
+       help
+         This option allows you to match against IPVS properties of a packet.
+
+         If unsure, say N.
+
 config NETFILTER_XT_MATCH_LENGTH
        tristate '"length" match support'
        depends on NETFILTER_ADVANCED
Index: nf-next-2.6/net/netfilter/Makefile
===================================================================
--- nf-next-2.6.orig/net/netfilter/Makefile     2010-07-22 10:13:21.000000000 
+0900
+++ nf-next-2.6/net/netfilter/Makefile  2010-07-22 10:13:42.000000000 +0900
@@ -77,6 +77,7 @@ obj-$(CONFIG_NETFILTER_XT_MATCH_HASHLIMI
 obj-$(CONFIG_NETFILTER_XT_MATCH_HELPER) += xt_helper.o
 obj-$(CONFIG_NETFILTER_XT_MATCH_HL) += xt_hl.o
 obj-$(CONFIG_NETFILTER_XT_MATCH_IPRANGE) += xt_iprange.o
+obj-$(CONFIG_NETFILTER_XT_MATCH_IPVS) += xt_ipvs.o
 obj-$(CONFIG_NETFILTER_XT_MATCH_LENGTH) += xt_length.o
 obj-$(CONFIG_NETFILTER_XT_MATCH_LIMIT) += xt_limit.o
 obj-$(CONFIG_NETFILTER_XT_MATCH_MAC) += xt_mac.o
Index: nf-next-2.6/net/netfilter/ipvs/ip_vs_proto.c
===================================================================
--- nf-next-2.6.orig/net/netfilter/ipvs/ip_vs_proto.c   2010-07-22 
10:13:21.000000000 +0900
+++ nf-next-2.6/net/netfilter/ipvs/ip_vs_proto.c        2010-07-22 
10:13:42.000000000 +0900
@@ -98,6 +98,7 @@ struct ip_vs_protocol * ip_vs_proto_get(
 
        return NULL;
 }
+EXPORT_SYMBOL(ip_vs_proto_get);
 
 
 /*
Index: nf-next-2.6/net/netfilter/xt_ipvs.c
===================================================================
--- /dev/null   1970-01-01 00:00:00.000000000 +0000
+++ nf-next-2.6/net/netfilter/xt_ipvs.c 2010-07-22 10:13:42.000000000 +0900
@@ -0,0 +1,189 @@
+/*
+ *     xt_ipvs - kernel module to match IPVS connection properties
+ *
+ *     Author: Hannes Eder <heder@xxxxxxxxxx>
+ */
+
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
+#include <linux/module.h>
+#include <linux/moduleparam.h>
+#include <linux/spinlock.h>
+#include <linux/skbuff.h>
+#ifdef CONFIG_IP_VS_IPV6
+#include <net/ipv6.h>
+#endif
+#include <linux/ip_vs.h>
+#include <linux/types.h>
+#include <linux/netfilter/x_tables.h>
+#include <linux/netfilter/x_tables.h>
+#include <linux/netfilter/xt_ipvs.h>
+#include <net/netfilter/nf_conntrack.h>
+
+#include <net/ip_vs.h>
+
+MODULE_AUTHOR("Hannes Eder <heder@xxxxxxxxxx>");
+MODULE_DESCRIPTION("Xtables: match IPVS connection properties");
+MODULE_LICENSE("GPL");
+MODULE_ALIAS("ipt_ipvs");
+MODULE_ALIAS("ip6t_ipvs");
+
+/* borrowed from xt_conntrack */
+static bool ipvs_mt_addrcmp(const union nf_inet_addr *kaddr,
+                           const union nf_inet_addr *uaddr,
+                           const union nf_inet_addr *umask,
+                           unsigned int l3proto)
+{
+       if (l3proto == NFPROTO_IPV4)
+               return ((kaddr->ip ^ uaddr->ip) & umask->ip) == 0;
+#ifdef CONFIG_IP_VS_IPV6
+       else if (l3proto == NFPROTO_IPV6)
+               return ipv6_masked_addr_cmp(&kaddr->in6, &umask->in6,
+                      &uaddr->in6) == 0;
+#endif
+       else
+               return false;
+}
+
+static bool
+ipvs_mt(const struct sk_buff *skb, struct xt_action_param *par)
+{
+       const struct xt_ipvs_mtinfo *data = par->matchinfo;
+       /* ipvs_mt_check ensures that family is only NFPROTO_IPV[46]. */
+       const u_int8_t family = par->family;
+       struct ip_vs_iphdr iph;
+       struct ip_vs_protocol *pp;
+       struct ip_vs_conn *cp;
+       bool match = true;
+
+       if (data->bitmask == XT_IPVS_IPVS_PROPERTY) {
+               match = skb->ipvs_property ^
+                       !!(data->invert & XT_IPVS_IPVS_PROPERTY);
+               goto out;
+       }
+
+       /* other flags than XT_IPVS_IPVS_PROPERTY are set */
+       if (!skb->ipvs_property) {
+               match = false;
+               goto out;
+       }
+
+       ip_vs_fill_iphdr(family, skb_network_header(skb), &iph);
+
+       if (data->bitmask & XT_IPVS_PROTO)
+               if ((iph.protocol == data->l4proto) ^
+                   !(data->invert & XT_IPVS_PROTO)) {
+                       match = false;
+                       goto out;
+               }
+
+       pp = ip_vs_proto_get(iph.protocol);
+       if (unlikely(!pp)) {
+               match = false;
+               goto out;
+       }
+
+       /*
+        * Check if the packet belongs to an existing entry
+        */
+       cp = pp->conn_out_get(family, skb, pp, &iph, iph.len, 1 /* inverse */);
+       if (unlikely(cp == NULL)) {
+               match = false;
+               goto out;
+       }
+
+       /*
+        * We found a connection, i.e. ct != 0, make sure to call
+        * __ip_vs_conn_put before returning.  In our case jump to out_put_con.
+        */
+
+       if (data->bitmask & XT_IPVS_VPORT)
+               if ((cp->vport == data->vport) ^
+                   !(data->invert & XT_IPVS_VPORT)) {
+                       match = false;
+                       goto out_put_cp;
+               }
+
+       if (data->bitmask & XT_IPVS_VPORTCTL)
+               if ((cp->control != NULL &&
+                    cp->control->vport == data->vportctl) ^
+                   !(data->invert & XT_IPVS_VPORTCTL)) {
+                       match = false;
+                       goto out_put_cp;
+               }
+
+       if (data->bitmask & XT_IPVS_DIR) {
+               enum ip_conntrack_info ctinfo;
+               struct nf_conn *ct = nf_ct_get(skb, &ctinfo);
+
+               if (ct == NULL || nf_ct_is_untracked(ct)) {
+                       match = false;
+                       goto out_put_cp;
+               }
+
+               if ((ctinfo >= IP_CT_IS_REPLY) ^
+                   !!(data->invert & XT_IPVS_DIR)) {
+                       match = false;
+                       goto out_put_cp;
+               }
+       }
+
+       if (data->bitmask & XT_IPVS_METHOD)
+               if (((cp->flags & IP_VS_CONN_F_FWD_MASK) == data->fwd_method) ^
+                   !(data->invert & XT_IPVS_METHOD)) {
+                       match = false;
+                       goto out_put_cp;
+               }
+
+       if (data->bitmask & XT_IPVS_VADDR) {
+               if (ipvs_mt_addrcmp(&cp->vaddr, &data->vaddr,
+                                   &data->vmask, family) ^
+                   !(data->invert & XT_IPVS_VADDR)) {
+                       match = false;
+                       goto out_put_cp;
+               }
+       }
+
+out_put_cp:
+       __ip_vs_conn_put(cp);
+out:
+       pr_debug("match=%d\n", match);
+       return match;
+}
+
+static int ipvs_mt_check(const struct xt_mtchk_param *par)
+{
+       if (par->family != NFPROTO_IPV4
+#ifdef CONFIG_IP_VS_IPV6
+           && par->family != NFPROTO_IPV6
+#endif
+               ) {
+               pr_info("protocol family %u not supported\n", par->family);
+               return -EINVAL;
+       }
+
+       return 0;
+}
+
+static struct xt_match xt_ipvs_mt_reg __read_mostly = {
+       .name       = "ipvs",
+       .revision   = 0,
+       .family     = NFPROTO_UNSPEC,
+       .match      = ipvs_mt,
+       .checkentry = ipvs_mt_check,
+       .matchsize  = XT_ALIGN(sizeof(struct xt_ipvs_mtinfo)),
+       .me         = THIS_MODULE,
+};
+
+static int __init ipvs_mt_init(void)
+{
+       return xt_register_match(&xt_ipvs_mt_reg);
+}
+
+static void __exit ipvs_mt_exit(void)
+{
+       xt_unregister_match(&xt_ipvs_mt_reg);
+}
+
+module_init(ipvs_mt_init);
+module_exit(ipvs_mt_exit);

--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>