|
Thanks, I learned this. You gave me a big cake.
2010/8/18 David Miller <davem@xxxxxxxxxxxxx>:
> From: Simon Horman <horms@xxxxxxxxxxxx>
> Date: Wed, 18 Aug 2010 09:21:49 +0900
>
>> [ CCing netdev for comment ]
>>
>> On Tue, Aug 17, 2010 at 12:25:56PM +0300, Julian Anastasov wrote:
> ...
>>> May be ip_vs_checksum_complete() is not needed here?
>>> Also, skb->csum is not valid for every ip_summed value.
>>> May be we need to apply CHECKSUM_PARTIAL kind of setup for the IPv6.
>>> Such example is net/ipv6/udp.c:udp6_ufo_send_check().
>>> Later dev_queue_xmit() and skb_checksum_help() should take care
>>> for the next steps. Something like this can be tested:
>>>
>>> icmph->icmp6_cksum = csum_ipv6_magic(&iph->saddr,
>>> &iph->daddr,
>>> skb->len - icmp_offset, IPPROTO_ICMPV6,
>>> 0);
>>> skb->csum_start = skb_network_header(skb) - skb->head +
>>> icmp_offset;
>>> skb->csum_offset = offsetof(struct icmp6hdr, icmp6_cksum);
>>> skb->ip_summed = CHECKSUM_PARTIAL;
>>>
>
> Yes, using CHECKSUM_PARTIAL unconditionally would work.
>
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
|
