LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [patch v2] ipvs: IPv6 tunnel mode

To: Hans Schillstrom <hans.schillstrom@xxxxxxxxxxxx>
Subject: Re: [patch v2] ipvs: IPv6 tunnel mode
Cc: Simon Horman <horms@xxxxxxxxxxxx>, "lvs-devel@xxxxxxxxxxxxxxx" <lvs-devel@xxxxxxxxxxxxxxx>, Julius Volz <juliusv@xxxxxxxxxx>
From: Julian Anastasov <ja@xxxxxx>
Date: Fri, 1 Oct 2010 10:48:49 +0300 (EEST)

        Hello,

On Fri, 1 Oct 2010, Hans Schillstrom wrote:

- Leave it as is ?

        This 3th option is better for the moment. I think,
saddr is selected correctly, see ip6_dst_lookup() and
ip6_dst_lookup_tail() in net/ipv6/ip6_output.c
But if you think using ipv6_addr_copy(&iph->daddr, &cp->daddr.in6);
is working then feel free to post a patch on top of
the previous patch. Because other code in kernel uses
resulting fl.fl6_dst, not rt6i_dst.

I prefer fl.fl6_dst right now since rt6i_dst gives a bad destination in
many cases.

I will do some more testing before posting the patch.

        ok, but note that now 'fl' is hidden in function
and not cached. I think fl.fl6_dst is read-only, so it
should contain cp->daddr.in6 in all cases.

Regards

--
Julian Anastasov <ja@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>