LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [patch v3] ipvs: IPv6 tunnel mode

To: Hans Schillstrom <hans.schillstrom@xxxxxxxxxxxx>
Subject: Re: [patch v3] ipvs: IPv6 tunnel mode
Cc: Simon Horman <horms@xxxxxxxxxxxx>, "lvs-devel@xxxxxxxxxxxxxxx" <lvs-devel@xxxxxxxxxxxxxxx>, Julius Volz <juliusv@xxxxxxxxxx>, Wensong Zhang <wensong@xxxxxxxxxxxx>
From: Julian Anastasov <ja@xxxxxx>
Date: Tue, 5 Oct 2010 10:11:09 +0300 (EEST)

        Hello,

On Tue, 5 Oct 2010, Hans Schillstrom wrote:

Hi Simon
Finally I got time to test this, and it works now with change of dest.

        You are using editor that changes tabs into spaces
and wraps long lines. The final patch does not look good.
Also, do not take the risk to use cp->dest->addr. Even if
one day IPv6 sync is supported, there is no rule that
says backup to have all real servers that are present
in master. NULL value for cp->dest is still supported.
Use &cp->daddr.in6 instead, it is perfectly valid for
TUN method.

@@ -750,8 +763,8 @@ ip_vs_tunnel_xmit_v6(struct sk_buff *skb
       be16_add_cpu(&iph->payload_len, sizeof(*old_iph));
       iph->priority           =       old_iph->priority;
       memset(&iph->flow_lbl, 0, sizeof(iph->flow_lbl));
-       iph->daddr              =       rt->rt6i_dst.addr;
-       iph->saddr              =       cp->vaddr.in6; /*
rt->rt6i_src.addr; */
+       ipv6_addr_copy(&iph->daddr, &cp->dest->addr.in6);
+       ipv6_addr_copy(&iph->saddr, &saddr);
       iph->hop_limit          =       old_iph->hop_limit;

       /* Another hack: avoid icmp_send in ip_fragment */

Regards

--
Julian Anastasov <ja@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>