LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [RFC PATCH 0/4] IPVS: Backup Adding Ipv6 and Persistence support

To: Julian Anastasov <ja@xxxxxx>
Subject: Re: [RFC PATCH 0/4] IPVS: Backup Adding Ipv6 and Persistence support
Cc: Simon Horman <horms@xxxxxxxxxxxx>, "wensong@xxxxxxxxxxxx" <wensong@xxxxxxxxxxxx>, "lvs-devel@xxxxxxxxxxxxxxx" <lvs-devel@xxxxxxxxxxxxxxx>, Daniel Lezcano <daniel.lezcano@xxxxxxx>
From: Hans Schillstrom <hans.schillstrom@xxxxxxxxxxxx>
Date: Wed, 27 Oct 2010 14:33:06 +0200
Hello
Some small changes, ...

On Wednesday 27 October 2010 11:19:20 Hans Schillstrom wrote:
> Hello
>
> On Tuesday 26 October 2010 23:25:10 Julian Anastasov wrote:
> >
> >     Hello,
[snip]
>
> /* Option types */
> #define IPVS_OPT_SEQ_DATA    1
> #define IPVS_OPT_PE_DATA     2
> #define IPVS_OPT_PE_NAME     3
>
>
> >     By this way later we can add more parameters. If we
> > want master to specify that some parameter is optional
> > we can allocate 1 bit (bit 7) in 'type' for this. Most
> > of the parameters must be supported by backup server.
> > If backup does not recognize some type it will skip the
> > connection entry if bit 7 is not set.
> >
> A New Spec of Type field:
>
> Bit    7        6        . . .      2         1           0
>   +----------+--------------------------+-------------+-------+
>   | Opt.Data |          Spare           | Packed IPv6 |  IPv6 |
>   +----------+--------------------------+-------------+-------+

I can see a better usage of it in Option Type so Type will look like this
    +-------------------------------------+-------------+-------+
    |                     Spare           | Packed IPv6 |  IPv6 |
    +-------------------------------------+-------------+-------+

And "Option Type" in option field would look like this

 Bit    7        6        . . .    0    7                      0
   +----------+----------------------+---------------------------+
   | Optional |      Option type     |    Option length          |
   +----------+----------------------+---------------------------+

We can have a better fine tuning of options in this way.

I.e. as Julian wrote but transferd to Option Type:

" If backup does not recognize some type it will skip the
  connection entry if bit 7 is not set."

--
Regards
Hans Schillstrom <hans.schillstrom@xxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>