|
Hello
>
>Hello,
>
>On Fri, 29 Apr 2011, Hans Schillstrom wrote:
>
>> This patch series handles exit from a network name space.
>>
>> REVISION
>>
>> This is version 3
>
> Great! Only one missing lock:
Ooops..
>
>Patch 3:
> Missing write_[un]lock_bh(&__ip_vs_svc_lock) in ip_vs_flush,
> now we use ip_vs_unlink_service_nolock.
>
>As you are going to create new version you can look also at these:
>
>Patch 5:
> Can you rename 'goto exit;' to 'goto cleanup;' or
> 'goto out;'
>
>Patch 6:
> Add at least one comma after 'enabled' here:
> netns(%d) enabled first service added
>
I'll send a new set.
Thanks
Hans
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
|
