LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH v2 7/8] ipvs: add support for sync threads

To: Simon Horman <horms@xxxxxxxxxxxx>
Subject: Re: [PATCH v2 7/8] ipvs: add support for sync threads
Cc: lvs-devel@xxxxxxxxxxxxxxx, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>, Aleksey Chudov <aleksey.chudov@xxxxxxxxx>
From: Julian Anastasov <ja@xxxxxx>
Date: Mon, 23 Apr 2012 22:43:33 +0300 (EEST)
        Hello,

On Mon, 23 Apr 2012, Simon Horman wrote:

> > +   return ((int) cp >> (1 + ilog2(sizeof(*cp)))) & ipvs->threads_mask;
> >  }
> 
> Hi Julian,
> 
> My gcc running on x86_64 doesn't seem to like this cast.
> 
> # gcc --version
> gcc (Debian 4.6.3-1) 4.6.3
> # make
> ...
>   CC      net/netfilter/ipvs/ip_vs_est.o
> net/netfilter/ipvs/ip_vs_sync.c: In function ‘select_master_thread_id’:
> net/netfilter/ipvs/ip_vs_sync.c:398:10: warning: cast from pointer to integer 
> of different size [-Wpointer-to-int-cast]

        Ops. I'll change this '(int)' with '(long)'. You
want new version for the whole patchset or just for this patch?

Regards

--
Julian Anastasov <ja@xxxxxx>
<Prev in Thread] Current Thread [Next in Thread>