Re: [PATCHv2 net-next 01/15] net: add skb_dst_set_unref

[David Miller <davem@xxxxxxxxxxxxx>]

From: Julian Anastasov <ja@xxxxxx>
Date: Sun, 10 Mar 2013 15:37:34 +0200 (EET)

>       The idea looks good, here is the implementation.
> Can I use it in this form for next patchset versions?

Yes, but with one minor change:

> -     if (unlikely(dst->flags & DST_NOCACHE)) {
> +     if (unlikely(dst->flags & DST_NOCACHE && !force)) {

I keep forgetting the && vs. & operator precedence, and so
do many other people, so please put parenthesis around
the "dst->flags & DST_NOCACHE" expression, thanks.
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html