[PATCH ipvs-next] ipvs: Remove rcu_read_unlock();rcu_read_lock();

To: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>, Julian Anastasov <ja@xxxxxx>
Subject: [PATCH ipvs-next] ipvs: Remove rcu_read_unlock();rcu_read_lock();
Cc: lvs-devel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, Wensong Zhang <wensong@xxxxxxxxxxxx>, Simon Horman <horms@xxxxxxxxxxxx>
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Thu, 25 Apr 2013 10:12:33 +0900
It is unclear to me that there is any utility in the following:


So this patch removes the two instances of the above from ip_vs_conn.c.

This was introduced in 7cf2eb7bccbe0d7a8ab1d1382c4faa2b3abf817f ("ipvs: fix
sparse warnings for ip_vs_conn listing") as part of cleaning up warnings
flagged by sparse.

Compile and sparse tested only.

Cc: Julian Anastasov <ja@xxxxxx>
Reported-by: Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>
 net/netfilter/ipvs/ip_vs_conn.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/net/netfilter/ipvs/ip_vs_conn.c b/net/netfilter/ipvs/ip_vs_conn.c
index a083bda..458dc68 100644
--- a/net/netfilter/ipvs/ip_vs_conn.c
+++ b/net/netfilter/ipvs/ip_vs_conn.c
@@ -975,8 +975,6 @@ static void *ip_vs_conn_array(struct seq_file *seq, loff_t 
                                return cp;
-               rcu_read_unlock();
-               rcu_read_lock();
        return NULL;
@@ -1015,8 +1013,6 @@ static void *ip_vs_conn_seq_next(struct seq_file *seq, 
void *v, loff_t *pos)
                        iter->l = &ip_vs_conn_tab[idx];
                        return cp;
-               rcu_read_unlock();
-               rcu_read_lock();
        iter->l = NULL;
        return NULL;

To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at

<Prev in Thread] Current Thread [Next in Thread>