LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH] ipvs: Fix reuse connection if real server is dead

To: Hans Schillstrom <hans@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH] ipvs: Fix reuse connection if real server is dead
Cc: Grzegorz Lyczba <grzegorz.lyczba@xxxxxxxxx>, lvs-devel@xxxxxxxxxxxxxxx, Simon Horman <horms@xxxxxxxxxxxx>
From: Julian Anastasov <ja@xxxxxx>
Date: Wed, 8 May 2013 11:53:33 +0300 (EEST)
        Hello,

On Wed, 8 May 2013, Hans Schillstrom wrote:

> > > +     unlikely(!atomic_read(&cp->dest->weight)) &&
> > 
> >     We should add '!iph.fragoffs &&' here.
> 
> Do we really need that?
> I don't think a SYN can be fragmented.

        SYNs are usually not fragmented. But we don't have the
right to search for SYN in a packet without TCP header. It can
be data fragment that contains 1 at this bit position, when
weight=0 such packets should be forwarded as part of existing
connection.

Regards

--
Julian Anastasov <ja@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>