Re: [PATCH] ip_vs_sh: fix build

To: <ja@xxxxxx>
Subject: Re: [PATCH] ip_vs_sh: fix build
Cc: <wensong@xxxxxxxxxxxx>, <pablo@xxxxxxxxxxxxx>, <horms@xxxxxxxxxxxx>, <lvs-devel@xxxxxxxxxxxxxxx>, <netdev@xxxxxxxxxxxxxxx>
From: "Jan Beulich" <jbeulich@xxxxxxxx>
Date: Thu, 30 May 2013 06:48:34 +0100
>>> Julian Anastasov <ja@xxxxxx> 05/29/13 9:28 PM >>>
>On Wed, 29 May 2013, Jan Beulich wrote:
>> --- 3.10-rc3/net/netfilter/ipvs/ip_vs_sh.c
>> +++ 3.10-rc3-ip_vs_sh-build/net/netfilter/ipvs/ip_vs_sh.c
>> @@ -67,8 +67,8 @@ struct ip_vs_sh_bucket {
>>  #define IP_VS_SH_TAB_MASK               (IP_VS_SH_TAB_SIZE - 1)
>>  struct ip_vs_sh_state {
>> -    struct ip_vs_sh_bucket        buckets[IP_VS_SH_TAB_SIZE];
>>      struct rcu_head            rcu_head;
>> +    struct ip_vs_sh_bucket        buckets[IP_VS_SH_TAB_SIZE];
>    Your fix reminds me about the same problem
>I noticed for LBLC (may be due to 10 bits) during development
>but forgot to check the other schedulers. The same solution
>is needed also for DH. OTOH, LBLC and LBLCR are correct.
>Do you prefer to provide similar fix for ip_vs_dh.c or
>I have to take care?

CONFIG_IP_VS_DH_TAB_BITS is always 8 (due to not coming from any
Kconfig setting), and hence not a problem at this point. If it is being planned
to make configurable, then that change should at once flip the structure


To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at

<Prev in Thread] Current Thread [Next in Thread>