Re: [PATCH] Sloppy TCP, SH rebalancing, SHP scheduling

[Julian Anastasov <ja@xxxxxx>]

        Hello,

On Mon, 17 Jun 2013, Alexander Frolkin wrote:

> Hi,
> 
> >     Add 'break' for this case when dest is NULL (no
> > dests). Then we have to add {} for all branches as per
> > CodingStyle:
> > 
> >     if (!is_unavailable(dest))
> >             return dest;
> >     if (dest) {
> >             IP_VS_DBG_BUF
> >     } else {
> >             IP_VS_DBG
> >             break;
> >     }
> 
> So if dest is NULL, there is no point trying to choose a different
> server?

        Wait, it seems is_unavailable() can succeed for other
reasons, so the 'if (!dest) ... break;' check should be first,
may be out of is_unavailable().

Regards

--
Julian Anastasov <ja@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html