LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH 1/2] kernel: remove unnecessary head file

To: JunweiZhang <junwei.zhang@xxxxxxxxx>
Subject: Re: [PATCH 1/2] kernel: remove unnecessary head file
Cc: wensong@xxxxxxxxxxxx, horms@xxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, Nicolas Dichtel <nicolas.dichtel@xxxxxxxxx>
From: Julian Anastasov <ja@xxxxxx>
Date: Fri, 21 Jun 2013 09:40:12 +0300 (EEST)
        Hello,

On Fri, 21 Jun 2013, junwei.zhang@xxxxxxxxx wrote:

> From: JunweiZhang <junwei.zhang@xxxxxxxxx>
> 
> ip_vs.h is not necessary for sysctl_binary.c.
> 
> prepare for the next patch to avoid compile issue.
> 
> Signed-off-by: JunweiZhang <junwei.zhang@xxxxxxxxx>
> Signed-off-by: Nicolas Dichtel <nicolas.dichtel@xxxxxxxxx>

        Both patches look good to me:

Reviewed-by: Julian Anastasov <ja@xxxxxx>

        Please use version descriptor in future, for example:

[PATCHv2 ...] ...

> ---
>  kernel/sysctl_binary.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/kernel/sysctl_binary.c b/kernel/sysctl_binary.c
> index aea4a9e..b609213 100644
> --- a/kernel/sysctl_binary.c
> +++ b/kernel/sysctl_binary.c
> @@ -3,7 +3,6 @@
>  #include "../fs/xfs/xfs_sysctl.h"
>  #include <linux/sunrpc/debug.h>
>  #include <linux/string.h>
> -#include <net/ip_vs.h>
>  #include <linux/syscalls.h>
>  #include <linux/namei.h>
>  #include <linux/mount.h>
> -- 
> 1.8.1.2

Regards

--
Julian Anastasov <ja@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>