LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH v2 net-next] net/sctp: Refactor SCTP skb checksum computation

To: Joe Stringer <joe@xxxxxxxxxxx>
Subject: Re: [PATCH v2 net-next] net/sctp: Refactor SCTP skb checksum computation
Cc: davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, pablo@xxxxxxxxxxxxx, horms@xxxxxxxxxxxx, jesse@xxxxxxxxxx
From: Julian Anastasov <ja@xxxxxx>
Date: Thu, 25 Jul 2013 08:08:11 +0300 (EEST)
        Hello,

On Thu, 25 Jul 2013, Joe Stringer wrote:

> This patch consolidates the SCTP checksum calculation code from various
> places to a single new function, sctp_compute_cksum(skb, offset).
> 
> Signed-off-by: Joe Stringer <joe@xxxxxxxxxxx>
> ---
> v2:
> * Use skb->data + offset for start position of checksum calculation
> * Fix existing bug in sctp_csum_check() where the incorrect offset was used
> * Remove redundant variable in sctp_nat_csum()

        v2 looks good to me, thanks!

Reviewed-by: Julian Anastasov <ja@xxxxxx>

> ---
>  include/net/sctp/checksum.h           |   15 +++++++++++++++
>  net/netfilter/ipvs/ip_vs_proto_sctp.c |   23 +++--------------------
>  net/netfilter/nf_nat_proto_sctp.c     |    8 +-------
>  net/sctp/input.c                      |   10 +---------
>  4 files changed, 20 insertions(+), 36 deletions(-)

Regards

--
Julian Anastasov <ja@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>