LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH] Allow override of CFLAGS

To: Daniel Borkmann <dborkman@xxxxxxxxxx>
Subject: Re: [PATCH] Allow override of CFLAGS
Cc: lvs-devel@xxxxxxxxxxxxxxx, Wensong Zhang <wensong@xxxxxxxxxxxx>, Julian Anastasov <ja@xxxxxx>, Jesper Dangaard Brouer <jbrouer@xxxxxxxxxx>
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Thu, 8 Aug 2013 18:00:22 +0900
On Thu, Aug 08, 2013 at 09:47:30AM +0200, Daniel Borkmann wrote:
> On 08/08/2013 06:59 AM, Simon Horman wrote:
> >When building ipvsadm this allows make to add to CFLAGS supplied
> >on the command line.
> >
> >This seems to make sense as Makefile and libipvs/Makefile
> >add different CFLAGS but it may be desirable to supply supplementary
> >flags when building ipvsadm.
> >
> >In particular the following may be useful when building ipvsadm
> >on Debian Jessie.
> >
> >make CFLAGS='-I/usr/include/libnl3' LIBS='-lnl-3 -lnl-genl-3 -lnl-3 -lpopt'
> 
> For libnl3, what about ...
> 
> cflags: $(shell pkg-config --cflags libnl-3.0) $(shell pkg-config --cflags 
> libnl-3.0)
> libs:   $(shell pkg-config --libs libnl-3.0) $(shell pkg-config --libs 
> libnl-genl-3.0)

That seems reasonable to me. Is it likely to work on a variety of
distributions?

> 
> >Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>
> >---
> >  Makefile | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/Makefile b/Makefile
> >index 6e36d79..c8c1eec 100644
> >--- a/Makefile
> >+++ b/Makefile
> >@@ -48,7 +48,7 @@ STATIC_LIBS        = libipvs/libipvs.a
> >  ifeq "${ARCH}" "sparc64"
> >      CFLAGS = -Wall -Wunused -Wstrict-prototypes -g -m64 -pipe 
> > -mcpu=ultrasparc -mcmodel=medlow
> >  else
> >-    CFLAGS = -Wall -Wunused -Wstrict-prototypes -g
> >+    CFLAGS = -I/usr/include/libnl3 -Wall -Wunused -Wstrict-prototypes -g
> >  endif
> >
> >
> >
> 
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>