Re: [PATCH v2 ipvs-next] net: ipvs: sctp: do not recalc sctp csum when ports didn't change

[Julian Anastasov <ja@xxxxxx>]

        Hello,

On Mon, 28 Oct 2013, Daniel Borkmann wrote:

>               /* Call application helper if needed */
> -             if (!ip_vs_app_pkt_out(cp, skb))
> +             if (!(ret = ip_vs_app_pkt_out(cp, skb)))
>                       return 0;

> -             if (!ip_vs_app_pkt_in(cp, skb))
> +             if (!(ret = ip_vs_app_pkt_in(cp, skb)))
>                       return 0;

        Sorry, just now noticed the errors from
scripts/checkpatch.pl:

ERROR: do not use assignment in if condition
#78: FILE: net/netfilter/ipvs/ip_vs_proto_sctp.c:103:
+               if (!(ret = ip_vs_app_pkt_out(cp, skb)))

ERROR: do not use assignment in if condition
#120: FILE: net/netfilter/ipvs/ip_vs_proto_sctp.c:149:
+               if (!(ret = ip_vs_app_pkt_in(cp, skb)))

total: 2 errors, 0 warnings, 81 lines checked

        I know that you copied the TCP logic that was
added by me but now we should split the complex conditions
at both places:

        ret = ...
        if (!ret)
                return 0;

        Otherwise patch looks good and I'll ack v3 with
the above changes.

Regards

--
Julian Anastasov <ja@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html