LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [Patch resend nf] ipvs: fix AF assignment in ip_vs_conn_new()

To: Julian Anastasov <ja@xxxxxx>
Subject: Re: [Patch resend nf] ipvs: fix AF assignment in ip_vs_conn_new()
Cc: netfilter-devel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, Wensong Zhang <wensong@xxxxxxxxxxxx>, Simon Horman <horms@xxxxxxxxxxxx>, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>, Patrick McHardy <kaber@xxxxxxxxx>, Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>
From: Michal Kubecek <mkubecek@xxxxxxx>
Date: Thu, 30 Jan 2014 08:39:04 +0100
On Wed, Jan 29, 2014 at 11:24:17PM +0200, Julian Anastasov wrote:
> > diff --git a/net/netfilter/ipvs/ip_vs_conn.c 
> > b/net/netfilter/ipvs/ip_vs_conn.c
> > index 59a1a85..282b39b 100644
> > --- a/net/netfilter/ipvs/ip_vs_conn.c
> > +++ b/net/netfilter/ipvs/ip_vs_conn.c
> > @@ -871,11 +871,11 @@ ip_vs_conn_new(const struct ip_vs_conn_param *p,
> >     cp->protocol       = p->protocol;
> >     ip_vs_addr_set(p->af, &cp->caddr, p->caddr);
> >     cp->cport          = p->cport;
> > -   ip_vs_addr_set(p->af, &cp->vaddr, p->vaddr);
> > -   cp->vport          = p->vport;
> > -   /* proto should only be IPPROTO_IP if d_addr is a fwmark */
> > +   /* proto should only be IPPROTO_IP if p->vaddr is a fwmark */
> >     ip_vs_addr_set(p->protocol == IPPROTO_IP ? AF_UNSPEC : p->af,
> > -                  &cp->daddr, daddr);
> > +                  &cp->vaddr, vaddr);
> 
>       Patch does not compile due to vaddr and p->daddr
> usage but you are in the right direction. Such change should
> fix a problem where connection templates don't get full
> IPv6 address for the real server, only the first 4 bytes
> are copied and as result it works only for IPv4.

Sorry for that, looks like I ran the test build after adapting to
current code with a config which didn't actually compile this file.
I'll send a v2 after testing a fixed version and I'll also extend the
commit message to describe the outcome.

                                                      Michal Kubecek

--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>