![]() |
lvs-devel
|
| To: | Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> |
|---|---|
| Subject: | [PATCH 1/2] ipvs: remove null test before kfree |
| Cc: | lvs-devel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, Wensong Zhang <wensong@xxxxxxxxxxxx>, Julian Anastasov <ja@xxxxxx>, Fabian Frederick <fabf@xxxxxxxxx>, Simon Horman <horms@xxxxxxxxxxxx> |
| From: | Simon Horman <horms@xxxxxxxxxxxx> |
| Date: | Wed, 16 Jul 2014 10:11:29 +0900 |
From: Fabian Frederick <fabf@xxxxxxxxx>
Fix checkpatch warning:
WARNING: kfree(NULL) is safe this check is probably not required
Signed-off-by: Fabian Frederick <fabf@xxxxxxxxx>
Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>
---
net/netfilter/ipvs/ip_vs_sync.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/netfilter/ipvs/ip_vs_sync.c b/net/netfilter/ipvs/ip_vs_sync.c
index db80126..eadffb2 100644
--- a/net/netfilter/ipvs/ip_vs_sync.c
+++ b/net/netfilter/ipvs/ip_vs_sync.c
@@ -886,8 +886,7 @@ static void ip_vs_proc_conn(struct net *net, struct
ip_vs_conn_param *param,
cp = ip_vs_conn_new(param, daddr, dport, flags, dest, fwmark);
rcu_read_unlock();
if (!cp) {
- if (param->pe_data)
- kfree(param->pe_data);
+ kfree(param->pe_data);
IP_VS_DBG(2, "BACKUP, add new conn. failed\n");
return;
}
--
2.0.0
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [PATCH 2/2] ipvs: Remove dead debug code, Simon Horman |
|---|---|
| Next by Date: | [GIT PULL nf-next 0/2] IPVS Updates for v3.17, Simon Horman |
| Previous by Thread: | [PATCH 2/2] ipvs: Remove dead debug code, Simon Horman |
| Next by Thread: | Re: [GIT PULL nf-next 0/2] IPVS Updates for v3.17, Pablo Neira Ayuso |
| Indexes: | [Date] [Thread] [Top] [All Lists] |