LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH ipvs] ipvs: Add selftests for ipvs

To: Julian Anastasov <ja@xxxxxx>
Subject: Re: [PATCH ipvs] ipvs: Add selftests for ipvs
Cc: Alex Gartrell <agartrell@xxxxxx>, horms@xxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, kernel-team@xxxxxx
From: Daniel Borkmann <dborkman@xxxxxxxxxx>
Date: Thu, 14 Aug 2014 09:09:59 +0200
On 08/14/2014 09:02 AM, Julian Anastasov wrote:

        Hello,

On Wed, 13 Aug 2014, Alex Gartrell wrote:

Here's a basic python framework for doing selftests on ipvs.

        This is interesting work. I, personally, didn't
played with such kind of tools, so if you don't get other
response here feel free to contact netdev, DaveM,
Andrew Morton or even Linus for applying the patch.
I don't know if some part of the code (IPv4/IPv6 headers)
can be useful for other future tests, so CC-ing netdev
would be a good idea.

Agreed, that's great to have a selftest suite for ipvs!

One minor note, for networking there is so far a small set
of tests under tools/testing/selftests/net/ .

You might want to consider adding it there and reorganizing
the structure as follows, for example:

tools/testing/selftests/net/ipvs/    -- your code
tools/testing/selftests/net/packet/  -- for existing psock* tests
tools/testing/selftests/net/misc/    -- general socket tests

net-next is currently closed due to the merge window, but
development should open very soon again, Dave always announces
this on netdev.

Signed-off-by: Alex Gartrell <agartrell@xxxxxx>
---
  tools/testing/selftests/ipvs/.gitignore            |   1 +
  tools/testing/selftests/ipvs/Makefile              |  14 +
  tools/testing/selftests/ipvs/general_ipvs_tests.py |  87 ++++++
  tools/testing/selftests/ipvs/network_headers.py    | 315 +++++++++++++++++++++
  tools/testing/selftests/ipvs/network_test_utils.py |  93 ++++++
  tools/testing/selftests/ipvs/test-ipvs.py          |  17 ++
  6 files changed, 527 insertions(+)
  create mode 100644 tools/testing/selftests/ipvs/.gitignore
  create mode 100644 tools/testing/selftests/ipvs/Makefile
  create mode 100644 tools/testing/selftests/ipvs/general_ipvs_tests.py
  create mode 100644 tools/testing/selftests/ipvs/network_headers.py
  create mode 100644 tools/testing/selftests/ipvs/network_test_utils.py
  create mode 100644 tools/testing/selftests/ipvs/test-ipvs.py

Regards

--
Julian Anastasov <ja@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>