Re: [PATCH net-next] ipvs: remove unnecessary assignment in __ip_vs_get_out_rt

[Julian Anastasov <ja@xxxxxx>]

        Hello,

On Mon, 6 Oct 2014, Alex Gartrell wrote:

> It is a precondition of the function that daddr be equal to dest->addr.ip
> if dest is non-NULL, so this additional assignment is just confusing for
> stupid engineers like me.
> 
> Signed-off-by: Alex Gartrell <agartrell@xxxxxx>

Acked-by: Julian Anastasov <ja@xxxxxx>

        Looks like this line appeared unexpectedly
in commit "ipvs: Eliminate rt->rt_dst usage in __ip_vs_get_out_rt()."

> ---
>  net/netfilter/ipvs/ip_vs_xmit.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/net/netfilter/ipvs/ip_vs_xmit.c b/net/netfilter/ipvs/ip_vs_xmit.c
> index 91f17c1..5efa597 100644
> --- a/net/netfilter/ipvs/ip_vs_xmit.c
> +++ b/net/netfilter/ipvs/ip_vs_xmit.c
> @@ -293,7 +293,6 @@ __ip_vs_get_out_rt(int skb_af, struct sk_buff *skb, 
> struct ip_vs_dest *dest,
>                                 &dest->addr.ip, &dest_dst->dst_saddr.ip,
>                                 atomic_read(&rt->dst.__refcnt));
>               }
> -             daddr = dest->addr.ip;
>               if (ret_saddr)
>                       *ret_saddr = dest_dst->dst_saddr.ip;
>       } else {
> -- 
> Alex Gartrell <agartrell@xxxxxx>

Regards

--
Julian Anastasov <ja@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html