![]() |
lvs-devel
|
| To: | Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx> |
|---|---|
| Subject: | [PATCH nf-next] ipvs: remove unnecessary assignment in __ip_vs_get_out_rt |
| Cc: | lvs-devel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, Wensong Zhang <wensong@xxxxxxxxxxxx>, Julian Anastasov <ja@xxxxxx>, Alex Gartrell <agartrell@xxxxxx>, Simon Horman <horms@xxxxxxxxxxxx> |
| From: | Simon Horman <horms@xxxxxxxxxxxx> |
| Date: | Tue, 28 Oct 2014 09:59:20 +0900 |
From: Alex Gartrell <agartrell@xxxxxx>
It is a precondition of the function that daddr be equal to dest->addr.ip
if dest is non-NULL, so this additional assignment is just confusing for
stupid engineers like me.
Signed-off-by: Alex Gartrell <agartrell@xxxxxx>
Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>
---
net/netfilter/ipvs/ip_vs_xmit.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/netfilter/ipvs/ip_vs_xmit.c b/net/netfilter/ipvs/ip_vs_xmit.c
index 91f17c1..5efa597 100644
--- a/net/netfilter/ipvs/ip_vs_xmit.c
+++ b/net/netfilter/ipvs/ip_vs_xmit.c
@@ -293,7 +293,6 @@ __ip_vs_get_out_rt(int skb_af, struct sk_buff *skb, struct
ip_vs_dest *dest,
&dest->addr.ip, &dest_dst->dst_saddr.ip,
atomic_read(&rt->dst.__refcnt));
}
- daddr = dest->addr.ip;
if (ret_saddr)
*ret_saddr = dest_dst->dst_saddr.ip;
} else {
--
2.1.1
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH net-next] ipvs: remove unnecessary assignment in __ip_vs_get_out_rt, Simon Horman |
|---|---|
| Next by Date: | [GIT PULL nf-next] IPVS Updates for v3.19, Simon Horman |
| Previous by Thread: | [GIT PULL nf-next] IPVS Updates for v3.19, Simon Horman |
| Next by Thread: | Re: [GIT PULL nf-next] IPVS Updates for v3.19, Pablo Neira Ayuso |
| Indexes: | [Date] [Thread] [Top] [All Lists] |