LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH ipvs] ipvs: call skb_sender_cpu_clear

To: Julian Anastasov <ja@xxxxxx>
Subject: Re: [PATCH ipvs] ipvs: call skb_sender_cpu_clear
Cc: lvs-devel@xxxxxxxxxxxxxxx
From: Simon Horman <horms@xxxxxxxxxxxx>
Date: Fri, 10 Jul 2015 15:18:40 +0900
On Thu, Jul 09, 2015 at 09:43:39PM +0300, Julian Anastasov wrote:
> 
>       Hello,
> 
> On Thu, 9 Jul 2015, Simon Horman wrote:
> 
> > On Thu, Jul 09, 2015 at 11:15:27AM +0300, Julian Anastasov wrote:
> > > Reset XPS's sender_cpu on forwarding.
> > > 
> > > Signed-off-by: Julian Anastasov <ja@xxxxxx>
> > > ---
> > >  net/netfilter/ipvs/ip_vs_xmit.c | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > > 
> > >  I see similar patches for other forwarding places...
> > > that is the reason for this patch.
> > 
> > Am I right in thinking this is not a bug fix?
> 
>       I saw Eric fixes for sender_cpu. Here are
> some references:
> 
> - from today @netdev, targets net tree:
> bridge: fix potential crash in __netdev_pick_tx()
> 
> - this commit explains the problem:
> commit c29390c6dfee ("xps: must clear sender_cpu before forwarding")

Thanks, I have queued this up in the ipvs tree with

Fixes: 2bd82484bb4c ("xps: fix xps for stacked devices")

--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>