LVS
lvs-devel
Google
 
Web LinuxVirtualServer.org

Re: [PATCH] ipvs:Fix locking requirements in the function ip_vs_unlink_s

To: Nicholas Krause <xerofoify@xxxxxxxxx>
Subject: Re: [PATCH] ipvs:Fix locking requirements in the function ip_vs_unlink_service
Cc: wensong@xxxxxxxxxxxx, horms@xxxxxxxxxxxx, pablo@xxxxxxxxxxxxx, kaber@xxxxxxxxx, kadlec@xxxxxxxxxxxxxxxxx, davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
From: Julian Anastasov <ja@xxxxxx>
Date: Sat, 12 Sep 2015 09:20:21 +0300 (EEST)
        Hello,

On Sat, 12 Sep 2015, Nicholas Krause wrote:

> This fixes locking requirements in the function ip_vs_unlink_service
> to properly use bottom half spinlocking around the call to the function
> __ip_vs_del_service  in order to meet the locking that this paricular
> function requires as stated in it's comments related to locking.

> +     spin_lock_bh(&svc->sched_lock);
>       __ip_vs_del_service(svc, cleanup);
> +     spin_unlock_bh(&svc->sched_lock);

        BH locking is not needed anymore. Also, sched_lock is
used by schedulers to protect only access to svc->sched_data
fields.

        It seems the comment is outdated after
commit ceec4c381681 ("ipvs: convert services to rcu").

Regards

--
Julian Anastasov <ja@xxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread] Current Thread [Next in Thread>