lvs-devel
|
To: | "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx>, David Miller <davem@xxxxxxxxxxxxx> |
---|---|
Subject: | Re: [PATCH net-next 06/15] ipv4: Merge ip_local_out and ip_local_out_sk |
Cc: | netfilter-devel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, Eric Dumazet <eric.dumazet@xxxxxxxxx> |
From: | Nicolas Dichtel <nicolas.dichtel@xxxxxxxxx> |
Date: | Wed, 7 Oct 2015 16:48:59 +0200 |
Le 06/10/2015 20:53, Eric W. Biederman a écrit : It is confusing and silly hiding a paramater so modify all of the callers to pass in the appropriate socket or skb->sk if no socket is known. Signed-off-by: "Eric W. Biederman" <ebiederm@xxxxxxxxxxxx> --- [snip] @@ -456,7 +456,7 @@ packet_routed: skb->priority = sk->sk_priority; skb->mark = sk->sk_mark; - res = ip_local_out(skb); + res = ip_local_out(sk, skb); As stated in the comment at the top of this function (ip_queue_xmit()), skb->sk can be different from sk. See also commit b0270e91014d ("ipv4: add a sock pointer to ip_queue_xmit()"). Not sure if this change is right. -- To unsubscribe from this list: send the line "unsubscribe lvs-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html |
Previous by Date: | Re: [PATCH net-next 01/15] ipv4: Fix ip_local_out_sk by passing the sk into __ip_local_out_sk, Nicolas Dichtel |
---|---|
Next by Date: | Re: [PATCH net-next 06/15] ipv4: Merge ip_local_out and ip_local_out_sk, Eric W. Biederman |
Previous by Thread: | [PATCH net-next 06/15] ipv4: Merge ip_local_out and ip_local_out_sk, Eric W. Biederman |
Next by Thread: | Re: [PATCH net-next 06/15] ipv4: Merge ip_local_out and ip_local_out_sk, Eric W. Biederman |
Indexes: | [Date] [Thread] [Top] [All Lists] |