![]() |
lvs-devel
|
| To: | Wensong Zhang <wensong@xxxxxxxxxxxx>, Simon Horman <horms@xxxxxxxxxxxx>, Julian Anastasov <ja@xxxxxx>, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>, Patrick McHardy <kaber@xxxxxxxxx>, Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx |
|---|---|
| Subject: | [PATCH v2 4/5] ipvs: Lock socket before setting SK_CAN_REUSE |
| Cc: | Quentin Armitage <quentin@xxxxxxxxxxxxxxx> |
| From: | Quentin Armitage <quentin@xxxxxxxxxxxxxxx> |
| Date: | Tue, 14 Jun 2016 15:24:21 +0100 |
When other settings are changed in the socket it is locked, so
lock the socket before setting SK_CAN_REUSE.
Signed-off-by: Quentin Armitage <quentin@xxxxxxxxxxxxxxx>
---
net/netfilter/ipvs/ip_vs_sync.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/net/netfilter/ipvs/ip_vs_sync.c b/net/netfilter/ipvs/ip_vs_sync.c
index 0ca937a..734335a 100644
--- a/net/netfilter/ipvs/ip_vs_sync.c
+++ b/net/netfilter/ipvs/ip_vs_sync.c
@@ -1539,7 +1539,9 @@ static struct socket *make_receive_sock(struct netns_ipvs
*ipvs, int id, int ifi
}
/* it is equivalent to the REUSEADDR option in user-space */
+ lock_sock(sock->sk);
sock->sk->sk_reuse = SK_CAN_REUSE;
+ release_sock(sock->sk);
result = sysctl_sync_sock_size(ipvs);
if (result > 0)
set_sock_size(sock->sk, 0, result);
--
1.7.7.6
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
|
| Previous by Date: | [PATCH v2 5/5] ipvs: log additional sync daemon parameters, Quentin Armitage |
|---|---|
| Next by Date: | [PATCH v2 3/5] ipvs: Don't check result < 0 after setting result = 0, Quentin Armitage |
| Previous by Thread: | [PATCH v2 5/5] ipvs: log additional sync daemon parameters, Quentin Armitage |
| Next by Thread: | [PATCH v2 3/5] ipvs: Don't check result < 0 after setting result = 0, Quentin Armitage |
| Indexes: | [Date] [Thread] [Top] [All Lists] |