LVS
lvs-devel
[Top] [All Lists]
Google
 
Web LinuxVirtualServer.org
<prev [Date] next> <prev [Thread] next>

Re: [PATCH v2] netfilter: Clean up tests if NULL returned on failure

from [Jan Engelhardt] [Permanent Link]
To: SIMRAN SINGHAL <singhalsimran0@xxxxxxxxx>
Subject: Re: [PATCH v2] netfilter: Clean up tests if NULL returned on failure
Cc: wensong@xxxxxxxxxxxx, Simon Horman <horms@xxxxxxxxxxxx>, Julian Anastasov <ja@xxxxxx>, Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>, Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, outreachy-kernel <outreachy-kernel@xxxxxxxxxxxxxxxx>
From: Jan Engelhardt <jengelh@xxxxxxx>
Date: Wed, 29 Mar 2017 11:33:54 +0200 (CEST) 
On Wednesday 2017-03-29 11:15, SIMRAN SINGHAL wrote:
>>>>>>       dest = kzalloc(sizeof(struct ip_vs_dest), GFP_KERNEL);
>>>>>>-      if (dest == NULL)
>>>>>>+      if (!dest)
>>>>>>               return -ENOMEM;
>
>But, according to me we should prefer !var over ( var ==NULL ) according to the
>coding style

Where does it say that?
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [PATCH v2] netfilter: Clean up tests if NULL returned on failure, SIMRAN SINGHAL
Next by Date:  [PATCH] net: netfilter: Replace explicit NULL comparison with ! operator, Arushi Singhal
Previous by Thread:  Re: [PATCH v2] netfilter: Clean up tests if NULL returned on failure, SIMRAN SINGHAL
Next by Thread:  [PATCH] net: netfilters: Remove unnecessary parenthesis, Arushi Singhal
Indexes:  [Date] [Thread] [Top] [All Lists]