Re: [PATCH] net: netfilter: Replace explicit NULL comparison with ! oper

To:	Arushi Singhal <arushisinghal19971997@xxxxxxxxx>
Subject:	Re: [PATCH] net: netfilter: Replace explicit NULL comparison with ! operator
Cc:	wensong@xxxxxxxxxxxx, Simon Horman <horms@xxxxxxxxxxxx>, outreachy-kernel@xxxxxxxxxxxxxxxx, Julian Anastasov <ja@xxxxxx>, Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxxxxxx>, davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
From:	Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
Date:	Tue, 4 Apr 2017 19:56:00 +0200

To:

Arushi Singhal <arushisinghal19971997@xxxxxxxxx>

Subject:

Re: [PATCH] net: netfilter: Replace explicit NULL comparison with ! operator

Cc:

wensong@xxxxxxxxxxxx, Simon Horman <horms@xxxxxxxxxxxx>, outreachy-kernel@xxxxxxxxxxxxxxxx, Julian Anastasov <ja@xxxxxx>, Jozsef Kadlecsik <kadlec@xxxxxxxxxxxxxxxxx>, davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, lvs-devel@xxxxxxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxx, coreteam@xxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx

From:

Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>

Date:

Tue, 4 Apr 2017 19:56:00 +0200

On Tue, Apr 04, 2017 at 01:41:11PM -0400, Simon Horman wrote:
> On Wed, Mar 29, 2017 at 03:45:01PM +0530, Arushi Singhal wrote:
> > Replace explicit NULL comparison with ! operator to simplify code.
> > 
> > Signed-off-by: Arushi Singhal <arushisinghal19971997@xxxxxxxxx>
> > ---
> >  net/netfilter/ipvs/ip_vs_ctl.c         |  8 ++---
> >  net/netfilter/ipvs/ip_vs_proto.c       |  8 ++---
> 
> I count 18 instances of "!= NULL in net/netfilter/ipvs/ip_vs_proto but this
> patch only seems to update 8 of them. I would prefer to fix all or none of
> them.

Agreed.

Please address all instances and resubmit.
--
To unsubscribe from this list: send the line "unsubscribe lvs-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

<Prev in Thread]	Current Thread	[Next in Thread>
Re: [PATCH] net: netfilter: Replace explicit NULL comparison with ! operator, Simon Horman Re: [PATCH] net: netfilter: Replace explicit NULL comparison with ! operator, Pablo Neira Ayuso <=

Previous by Date:	Re: [PATCH] net: netfilters: Remove unnecessary parenthesis, Simon Horman
Next by Date:	Re: [PATCH] net: netfilter: Use seq_puts()/seq_putc() where possible, Simon Horman
Previous by Thread:	Re: [PATCH] net: netfilter: Replace explicit NULL comparison with ! operator, Simon Horman
Next by Thread:	Re: [PATCH] net: netfilters: Remove unnecessary parenthesis, Simon Horman
Indexes:	[Date] [Thread] [Top] [All Lists]

Previous by Date:

Re: [PATCH] net: netfilters: Remove unnecessary parenthesis, Simon Horman

Next by Date:

Re: [PATCH] net: netfilter: Use seq_puts()/seq_putc() where possible, Simon Horman

Previous by Thread:

Re: [PATCH] net: netfilter: Replace explicit NULL comparison with ! operator, Simon Horman

Next by Thread:

Re: [PATCH] net: netfilters: Remove unnecessary parenthesis, Simon Horman

Indexes:

[Date] [Thread] [Top] [All Lists]